Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Unified Diff: net/http/http_auth.h

Issue 242135: Merge r25564 and r26588 from the trunk.... (Closed) Base URL: svn://chrome-svn/chrome/branches/195/src/
Patch Set: Undo an extraneous comment change Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/http/http_auth.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_auth.h
===================================================================
--- net/http/http_auth.h (revision 28069)
+++ net/http/http_auth.h (working copy)
@@ -75,6 +75,7 @@
// |*handler| is set to NULL.
static void CreateAuthHandler(const std::string& challenge,
Target target,
+ const GURL& origin,
scoped_refptr<HttpAuthHandler>* handler);
// Iterate through the challenge headers, and pick the best one that
@@ -84,11 +85,15 @@
// |*handler| is unchanged. If no supported challenge was found, |*handler|
// is set to NULL.
//
+ // |origin| is used by the NTLM authentication scheme to construct the
+ // service principal name. It is ignored by other schemes.
+ //
// TODO(wtc): Continuing to use the existing handler in |*handler| (for
// NTLM) is new behavior. Rename ChooseBestChallenge to fully encompass
// what it does now.
static void ChooseBestChallenge(const HttpResponseHeaders* headers,
Target target,
+ const GURL& origin,
scoped_refptr<HttpAuthHandler>* handler);
// ChallengeTokenizer breaks up a challenge string into the the auth scheme
« no previous file with comments | « no previous file | net/http/http_auth.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698