Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2420543004: Improve the page download: (Closed)

Created:
4 years, 2 months ago by Dmitry Titov
Modified:
4 years, 2 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

Improve the page download: - observe page loading in the current tab and captrue it when it is ready directly from the tab. - if tab renavigates/closes, pass the request back to RequestCoordinator BUG=654955 Review-Url: https://codereview.chromium.org/2412823002 Cr-Commit-Position: refs/heads/master@{#425077} (cherry picked from commit 02d38c0b50c55dadb98039dbc58a70ad2c7c8a15) Committed: https://chromium.googlesource.com/chromium/src/+/e6afa7cf3c0dd8655dad4b40cb74abe3c3ba8078

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+230 lines, -100 lines) Patch
M chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc View 6 chunks +49 lines, -67 lines 0 comments Download
M chrome/browser/android/offline_pages/recent_tab_helper.h View 3 chunks +43 lines, -6 lines 0 comments Download
M chrome/browser/android/offline_pages/recent_tab_helper.cc View 7 chunks +99 lines, -14 lines 0 comments Download
M chrome/browser/android/offline_pages/recent_tab_helper_unittest.cc View 2 chunks +16 lines, -2 lines 0 comments Download
M components/offline_pages/background/request_coordinator.cc View 1 chunk +13 lines, -3 lines 0 comments Download
M components/offline_pages/background/request_coordinator_unittest.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M components/offline_pages/offline_page_model.h View 1 chunk +4 lines, -1 line 0 comments Download
M components/offline_pages/offline_page_model_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M components/offline_pages/offline_page_model_impl.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
Dmitry Titov
4 years, 2 months ago (2016-10-14 01:00:04 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e6afa7cf3c0dd8655dad4b40cb74abe3c3ba8078.

Powered by Google App Engine
This is Rietveld 408576698