Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1963)

Unified Diff: chrome/browser/android/offline_pages/recent_tab_helper_unittest.cc

Issue 2420543004: Improve the page download: (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/offline_pages/recent_tab_helper_unittest.cc
diff --git a/chrome/browser/android/offline_pages/recent_tab_helper_unittest.cc b/chrome/browser/android/offline_pages/recent_tab_helper_unittest.cc
index cc4073391d75fcc2f47f993882d30586a8e0cfca..8d484ebf20e18f4b72a6c5bd6c4b1c2743b0c034 100644
--- a/chrome/browser/android/offline_pages/recent_tab_helper_unittest.cc
+++ b/chrome/browser/android/offline_pages/recent_tab_helper_unittest.cc
@@ -211,10 +211,8 @@ TEST_F(RecentTabHelperTest, Basic) {
TEST_F(RecentTabHelperTest, SimpleCapture) {
NavigateAndCommit(kTestPageUrl);
- EXPECT_FALSE(recent_tab_helper()->is_page_ready_for_snapshot());
recent_tab_helper()->DocumentOnLoadCompletedInMainFrame();
RunUntilIdle();
- EXPECT_TRUE(recent_tab_helper()->is_page_ready_for_snapshot());
EXPECT_TRUE(model()->is_loaded());
GetAllPages();
EXPECT_EQ(1U, all_pages().size());
@@ -313,4 +311,20 @@ TEST_F(RecentTabHelperTest, FeatureNotEnabled) {
EXPECT_EQ(0U, all_pages().size());
}
+TEST_F(RecentTabHelperTest, DownloadRequest) {
+ NavigateAndCommit(kTestPageUrl);
+ recent_tab_helper()->ObserveAndDownloadCurrentPage(
+ ClientId("download", "id1"), 153l);
+ recent_tab_helper()->DocumentOnLoadCompletedInMainFrame();
+ RunUntilIdle();
+ EXPECT_TRUE(model()->is_loaded());
+ GetAllPages();
+ EXPECT_EQ(1U, all_pages().size());
+ const OfflinePageItem& page = all_pages()[0];
+ EXPECT_EQ(kTestPageUrl, page.url);
+ EXPECT_EQ("download", page.client_id.name_space);
+ EXPECT_EQ("id1", page.client_id.id);
+ EXPECT_EQ(153l, page.offline_id);
+}
+
} // namespace offline_pages
« no previous file with comments | « chrome/browser/android/offline_pages/recent_tab_helper.cc ('k') | components/offline_pages/background/request_coordinator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698