Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1672)

Unified Diff: components/offline_pages/offline_page_model.h

Issue 2420543004: Improve the page download: (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/offline_page_model.h
diff --git a/components/offline_pages/offline_page_model.h b/components/offline_pages/offline_page_model.h
index c1036b7b065f5d6a06c488481ead5ae6101cd485..cf6ef7417743ca9c26152ec20549ff1e7d0e9d85 100644
--- a/components/offline_pages/offline_page_model.h
+++ b/components/offline_pages/offline_page_model.h
@@ -81,10 +81,13 @@ class OfflinePageModel : public base::SupportsUserData {
virtual void AddObserver(Observer* observer) = 0;
virtual void RemoveObserver(Observer* observer) = 0;
+ static const int64_t kInvalidOfflineId = 0;
+
// Attempts to save a page addressed by |url| offline. Requires that the model
// is loaded. Generates a new offline id and returns
// it. |proposed_offline_id| is used for the offline_id for the saved file if
- // it is non-zero. If it is zero, a new, random ID will be generated.
+ // it is non-zero. If it is kInvalidOfflineId, a new, random ID will be
+ // generated.
virtual void SavePage(const GURL& url,
const ClientId& client_id,
int64_t proposed_offline_id,

Powered by Google App Engine
This is Rietveld 408576698