Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 2420413006: Android accessibility: fix word/character navigation in unfocused text fields (Closed)

Created:
4 years, 2 months ago by dmazzoni
Modified:
4 years, 1 month ago
Reviewers:
David Tseng
CC:
chromium-reviews, aboxhall+watch_chromium.org, nektar+watch_chromium.org, jam, yuzo+watch_chromium.org, je_julie, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Android accessibility: fix word/character navigation in unfocused text fields We have two different code paths for word / character granularity movement: 1. For static text, we update our internal state to keep track of a fake cursor 2. For editable text, we update the actual selection The purpose of #2 was to allow word/character navigation while editing a text field, but we weren't properly handling the case where it's an editable text field that isn't currently focused. The fix is to make sure we use code path #1 when navigating in a text field that isn't currently focused. BUG=656782 Committed: https://crrev.com/48cf22b54f806accf7dad031dc59cd29d6d51c34 Cr-Commit-Position: refs/heads/master@{#427392}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -2 lines) Patch
M content/browser/accessibility/browser_accessibility_manager_android.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_manager_android.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java View 3 chunks +6 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (5 generated)
dmazzoni
4 years, 2 months ago (2016-10-18 16:24:16 UTC) #2
David Tseng
lgtm The change itself seems fine given #1 is the way TalkBack achieves character/word movement ...
4 years, 2 months ago (2016-10-20 02:59:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2420413006/1
4 years, 1 month ago (2016-10-24 22:34:00 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_ng/builds/179638)
4 years, 1 month ago (2016-10-24 22:53:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2420413006/1
4 years, 1 month ago (2016-10-25 17:02:10 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-25 17:28:48 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-10-25 17:37:05 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/48cf22b54f806accf7dad031dc59cd29d6d51c34
Cr-Commit-Position: refs/heads/master@{#427392}

Powered by Google App Engine
This is Rietveld 408576698