Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java

Issue 2420413006: Android accessibility: fix word/character navigation in unfocused text fields (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/accessibility/browser_accessibility_manager_android.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java b/content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java
index b1cabade8c8e4e2395098d7e02c186740b523dd7..d22352771e22a978a02a4484a1d5281bf49d1a32 100644
--- a/content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java
+++ b/content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java
@@ -431,7 +431,8 @@ public class BrowserAccessibilityManager {
mSelectionEndIndex = -1;
}
mSelectionGranularity = granularity;
- if (nativeIsEditableText(mNativeObj, mAccessibilityFocusId)) {
+ if (nativeIsEditableText(mNativeObj, mAccessibilityFocusId)
+ && nativeIsFocused(mNativeObj, mAccessibilityFocusId)) {
mSelectionStartIndex = nativeGetEditableTextSelectionStart(
mNativeObj, mAccessibilityFocusId);
mSelectionEndIndex = nativeGetEditableTextSelectionEnd(
@@ -479,7 +480,8 @@ public class BrowserAccessibilityManager {
if (!extendSelection) {
mSelectionStartIndex = mSelectionEndIndex;
}
- if (nativeIsEditableText(mNativeObj, mAccessibilityFocusId)) {
+ if (nativeIsEditableText(mNativeObj, mAccessibilityFocusId)
+ && nativeIsFocused(mNativeObj, mAccessibilityFocusId)) {
nativeSetSelection(mNativeObj, mAccessibilityFocusId,
mSelectionStartIndex, mSelectionEndIndex);
}
@@ -1163,6 +1165,8 @@ public class BrowserAccessibilityManager {
private native boolean nativeIsNodeValid(long nativeBrowserAccessibilityManagerAndroid, int id);
private native boolean nativeIsEditableText(
long nativeBrowserAccessibilityManagerAndroid, int id);
+ private native boolean nativeIsFocused(
+ long nativeBrowserAccessibilityManagerAndroid, int id);
private native int nativeGetEditableTextSelectionStart(
long nativeBrowserAccessibilityManagerAndroid, int id);
private native int nativeGetEditableTextSelectionEnd(
« no previous file with comments | « content/browser/accessibility/browser_accessibility_manager_android.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698