Android accessibility should not treat whitespace-only nodes as interesting.

Android accessibility should not treat whitespace-only nodes as interesting.

When linearly navigating through nodes in the accessibility tree, don't treat
a leaf node with text as interesting if the text is only whitespace.
Also fix an issue where requesting the first "interesting" node
from the root of the tree could sometimes return the root itself, leading to
a cycle.

BUG=656779
Committed: https://crrev.com/100ba42f5f6b4ec409c5106749a65bdbb04c4328
Cr-Commit-Position: refs/heads/master@{#427172}

[dmazzoni, 2016-10-17 20:11:11]

The CQ bit was checked by dmazzoni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-17 20:11:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-17 23:28:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-17 23:28:17]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[dmazzoni, 2016-10-22 21:51:30]

dmazzoni@chromium.org changed reviewers:
+ aboxhall@chromium.org

[chromium-reviews, 2016-10-24 14:26:21]

+ // Otherwise, the interesting nodes are leaf nodes with non-whitespace 
text.
> + return PlatformIsLeaf() &&
> + !base::ContainsOnlyChars(GetText(), base::kWhitespaceUTF16);
> }

I thought that text nodes that contain only white space were already 
marked as ignored by Blink. How do they end up in the accessibility tree?

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[dmazzoni, 2016-10-24 15:04:52]

The original bug was actually filed about line breaks, i.e. <br> elements.
I think there are a few other exceptions in Blink where certain attributes
can make it not ignored. Also note that on the browser side nodes we mark
as not interesting are not hidden from the accessibility tree, they're just
skipped when doing linear navigation.

On Mon, Oct 24, 2016 at 7:26 AM Nektarios Paisios <nektar@google.com> wrote:

> + // Otherwise, the interesting nodes are leaf nodes with non-whitespace
> text.
>
> + return PlatformIsLeaf() &&
> + !base::ContainsOnlyChars(GetText(), base::kWhitespaceUTF16);
> }
>
>
> I thought that text nodes that contain only white space were already
> marked as ignored by Blink. How do they end up in the accessibility tree?
>
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[aboxhall, 2016-10-24 19:06:24]

lgtm

[dmazzoni, 2016-10-24 19:07:33]

The CQ bit was checked by dmazzoni@chromium.org

[commit-bot: I haz the power, 2016-10-24 19:08:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-24 22:25:41]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-24 22:28:04]

Description was changed from

==========
Android accessibility should not treat whitespace-only nodes as interesting.

When linearly navigating through nodes in the accessibility tree, don't treat
a leaf node with text as interesting if the text is only whitespace.
Also fix an issue where requesting the first "interesting" node
from the root of the tree could sometimes return the root itself, leading to
a cycle.

BUG=656779
==========

to

==========
Android accessibility should not treat whitespace-only nodes as interesting.

When linearly navigating through nodes in the accessibility tree, don't treat
a leaf node with text as interesting if the text is only whitespace.
Also fix an issue where requesting the first "interesting" node
from the root of the tree could sometimes return the root itself, leading to
a cycle.

BUG=656779

Committed: https://crrev.com/100ba42f5f6b4ec409c5106749a65bdbb04c4328
Cr-Commit-Position: refs/heads/master@{#427172}
==========

[commit-bot: I haz the power, 2016-10-24 22:28:05]

Patchset 1 (id:??) landed as
https://crrev.com/100ba42f5f6b4ec409c5106749a65bdbb04c4328
Cr-Commit-Position: refs/heads/master@{#427172}