Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 2420273002: Delete WebMediaPlayerAndroid (Closed)

Created:
4 years, 2 months ago by tguilbert
Modified:
3 years, 10 months ago
Reviewers:
kinuko, DaleCurtis
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, posciak+watch_chromium.org, avayvod+watch_chromium.org, nasko+codewatch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, mcasas+watch+vc_chromium.org, mlamouri+watch-media_chromium.org, miu+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Delete WebMediaPlayerAndroid The MediaPlayerRenderer is turned on by default in M57, and there does not seem to be any regressions after M57 hitting beta. This change deletes WMPA and the ability to switch between the old an the new path. The information surrounding the MediaPlayerRenderer can be found in crbug.com/619729 This change frees up 7.5 KiB. BUG=570711, 578311 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2420273002 Cr-Commit-Position: refs/heads/master@{#448488} Committed: https://chromium.googlesource.com/chromium/src/+/d7e079c0cbf1e00ef45a8fb98103c6d013a31c45

Patch Set 1 #

Patch Set 2 : Missed media_switches.h #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase (#2) #

Patch Set 5 : Updated comments #

Patch Set 6 : rebase #

Patch Set 7 : Cleanup RendererMediaSessionManager #

Patch Set 8 : Fix build error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1830 lines) Patch
M content/browser/frame_host/render_frame_host_impl.cc View 1 2 3 4 5 1 chunk +3 lines, -5 lines 0 comments Download
M content/renderer/BUILD.gn View 1 2 3 4 5 1 chunk +0 lines, -2 lines 0 comments Download
M content/renderer/media/android/renderer_media_player_manager.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
D content/renderer/media/android/webmediaplayer_android.h View 1 2 3 4 5 1 chunk +0 lines, -440 lines 0 comments Download
D content/renderer/media/android/webmediaplayer_android.cc View 1 2 3 4 5 1 chunk +0 lines, -1340 lines 0 comments Download
M content/renderer/render_frame_impl.h View 1 2 3 4 5 6 7 3 chunks +0 lines, -9 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 2 3 4 5 6 4 chunks +0 lines, -26 lines 0 comments Download
M media/base/media_switches.cc View 1 2 3 4 5 1 chunk +0 lines, -4 lines 0 comments Download
M media/blink/webmediaplayer_impl.cc View 1 2 3 4 5 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 33 (27 generated)
tguilbert
M57 hit beta last week. It seems like there weren't any regressions over the weekend.
3 years, 10 months ago (2017-02-06 21:56:29 UTC) #15
tguilbert
kinuko@, can you OWNERS review content/renderer/render_frame_impl.* and content/browser/* Thank you! Thomas
3 years, 10 months ago (2017-02-06 22:02:37 UTC) #17
DaleCurtis
lgtm \o/
3 years, 10 months ago (2017-02-06 22:22:58 UTC) #20
kinuko
lgtm!
3 years, 10 months ago (2017-02-06 23:43:43 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2420273002/140001
3 years, 10 months ago (2017-02-07 00:29:42 UTC) #30
commit-bot: I haz the power
3 years, 10 months ago (2017-02-07 01:17:20 UTC) #33
Message was sent while issue was closed.
Committed patchset #8 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/d7e079c0cbf1e00ef45a8fb98103...

Powered by Google App Engine
This is Rietveld 408576698