Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Unified Diff: media/blink/webmediaplayer_impl.cc

Issue 2420273002: Delete WebMediaPlayerAndroid (Closed)
Patch Set: Fix build error Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/base/media_switches.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/blink/webmediaplayer_impl.cc
diff --git a/media/blink/webmediaplayer_impl.cc b/media/blink/webmediaplayer_impl.cc
index 9ecacb5983e0177d6f4b5cada9846b2b966dec0d..a195bbffe433dd586df6ba14be3dffe79a5891dd 100644
--- a/media/blink/webmediaplayer_impl.cc
+++ b/media/blink/webmediaplayer_impl.cc
@@ -1608,10 +1608,11 @@ void WebMediaPlayerImpl::DataSourceInitialized(bool success) {
#if defined(OS_ANDROID)
// We can't play HLS URLs with WebMediaPlayerImpl, so in cases where they are
// encountered, instruct the HTML media element to create a new WebMediaPlayer
- // instance with the correct URL to trigger WebMediaPlayerAndroid creation.
+ // instance with the correct URL to trigger the creation of WMPI with a
+ // MediaPlayerRendererFactory instead.
//
- // TODO(tguilbert): Remove this code path once we have the ability to host a
- // MediaPlayer within a Mojo media renderer. http://crbug.com/580626
+ // TODO(tguilbert): Allow 'hotswapping' renderer factories to prevent reloads
+ // and/or rely on demuxer extracted MediaContainerNames. See crbug.com/663503.
if (data_source_ && !use_fallback_path_) {
const GURL url_after_redirects = data_source_->GetUrlAfterRedirects();
if (MediaCodecUtil::IsHLSURL(url_after_redirects)) {
« no previous file with comments | « media/base/media_switches.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698