[Autofill] Do not offer autofill suggestions on insecure forms

[Autofill] Do not offer autofill suggestions on insecure forms

The issue was that we would offer CC suggestions on forms that were in secure contexts, but that would POST to insecure URLs. We know require a secure context for the current page + an HTTPS scheme check on the form action.

BUG=652334, 630656
TEST=AutofillManagerTest, AutofillAssistantTest

Committed: https://crrev.com/d34769d95e75355f0a01b7989d218e7325d6cbfe
Cr-Commit-Position: refs/heads/master@{#425683}

[Mathieu, 2016-10-13 19:46:40]

The CQ bit was checked by mathp@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-13 19:47:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-13 19:59:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-13 19:59:44]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[Mathieu, 2016-10-14 14:30:22]

The CQ bit was checked by mathp@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-14 14:30:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-14 14:41:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-14 14:41:49]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[Mathieu, 2016-10-14 17:04:30]

The CQ bit was checked by mathp@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-14 17:05:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Mathieu, 2016-10-14 17:06:33]

Patchset #2 (id:20001) has been deleted

[Mathieu, 2016-10-14 17:06:42]

Patchset #2 (id:40001) has been deleted

[Mathieu, 2016-10-14 17:19:38]

The CQ bit was checked by mathp@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-14 17:19:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Mathieu, 2016-10-14 17:20:41]

Description was changed from

==========
[Autofill] Do not offer autofill suggestions on insecure forms

BUG=652334
TEST=AutofillManagerTest, AutofillAssistantTest
==========

to

==========
[Autofill] Do not offer autofill suggestions on insecure forms

The issue was that we would offer CC suggestions on forms that were in secure
contexts, but that would POST to insecure URLs. We know require a secure context
for the current page + an HTTPS scheme check on the form action.

BUG=652334
TEST=AutofillManagerTest, AutofillAssistantTest
==========

[Mathieu, 2016-10-14 17:21:57]

Patchset #1 (id:1) has been deleted

[Mathieu, 2016-10-14 17:22:04]

Patchset #1 (id:60001) has been deleted

[Mathieu, 2016-10-14 17:59:43]

Patchset #1 (id:80001) has been deleted

[Mathieu, 2016-10-14 18:03:55]

mathp@chromium.org changed reviewers:
+ sebsg@chromium.org

[Mathieu, 2016-10-14 18:03:56]

Hi Seb, can you have a look?

[Mathieu, 2016-10-14 21:20:18]

Description was changed from

==========
[Autofill] Do not offer autofill suggestions on insecure forms

The issue was that we would offer CC suggestions on forms that were in secure
contexts, but that would POST to insecure URLs. We know require a secure context
for the current page + an HTTPS scheme check on the form action.

BUG=652334
TEST=AutofillManagerTest, AutofillAssistantTest
==========

to

==========
[Autofill] Do not offer autofill suggestions on insecure forms

The issue was that we would offer CC suggestions on forms that were in secure
contexts, but that would POST to insecure URLs. We know require a secure context
for the current page + an HTTPS scheme check on the form action.

BUG=652334, 630656
TEST=AutofillManagerTest, AutofillAssistantTest
==========

[sebsg, 2016-10-17 13:37:07]

lgtm

[Mathieu, 2016-10-17 14:40:20]

The CQ bit was checked by mathp@chromium.org

[commit-bot: I haz the power, 2016-10-17 14:40:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-17 15:20:34]

Description was changed from

==========
[Autofill] Do not offer autofill suggestions on insecure forms

The issue was that we would offer CC suggestions on forms that were in secure
contexts, but that would POST to insecure URLs. We know require a secure context
for the current page + an HTTPS scheme check on the form action.

BUG=652334, 630656
TEST=AutofillManagerTest, AutofillAssistantTest
==========

to

==========
[Autofill] Do not offer autofill suggestions on insecure forms

The issue was that we would offer CC suggestions on forms that were in secure
contexts, but that would POST to insecure URLs. We know require a secure context
for the current page + an HTTPS scheme check on the form action.

BUG=652334, 630656
TEST=AutofillManagerTest, AutofillAssistantTest
==========

[commit-bot: I haz the power, 2016-10-17 15:20:36]

Committed patchset #1 (id:100001)

[commit-bot: I haz the power, 2016-10-17 15:24:33]

Description was changed from

==========
[Autofill] Do not offer autofill suggestions on insecure forms

The issue was that we would offer CC suggestions on forms that were in secure
contexts, but that would POST to insecure URLs. We know require a secure context
for the current page + an HTTPS scheme check on the form action.

BUG=652334, 630656
TEST=AutofillManagerTest, AutofillAssistantTest
==========

to

==========
[Autofill] Do not offer autofill suggestions on insecure forms

The issue was that we would offer CC suggestions on forms that were in secure
contexts, but that would POST to insecure URLs. We know require a secure context
for the current page + an HTTPS scheme check on the form action.

BUG=652334, 630656
TEST=AutofillManagerTest, AutofillAssistantTest

Committed: https://crrev.com/d34769d95e75355f0a01b7989d218e7325d6cbfe
Cr-Commit-Position: refs/heads/master@{#425683}
==========

[commit-bot: I haz the power, 2016-10-17 15:24:34]

Patchset 1 (id:??) landed as
https://crrev.com/d34769d95e75355f0a01b7989d218e7325d6cbfe
Cr-Commit-Position: refs/heads/master@{#425683}