[Autofill] Do not offer autofill suggestions on insecure forms

components/autofill/core/browser/autofill_metrics_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/core/browser/autofill_metrics.h"
 
 #include <stddef.h>
 
 #include <memory>
 #include <vector>
@@ skipping 1799 matching lines @@
 // logged once if the field is queried repeatedly.
 TEST_F(AutofillMetricsTest, PolledCreditCardSuggestions_DebounceLogs) {
   personal_data_->RecreateCreditCards(
       true /* include_local_credit_card */,
       false /* include_masked_server_credit_card */,
       false /* include_full_server_credit_card */);
 
   // Set up the form data.
   FormData form;
   form.name = ASCIIToUTF16("TestForm");
-  form.origin = GURL("http://example.com/form.html");
-  form.action = GURL("http://example.com/submit.html");
 
   FormFieldData field;
   std::vector<ServerFieldType> field_types;
   test::CreateTestFormField("Name on card", "cc-name", "", "text", &field);
   form.fields.push_back(field);
   field_types.push_back(CREDIT_CARD_NAME_FULL);
   test::CreateTestFormField("Credit card", "card", "", "text", &field);
   form.fields.push_back(field);
   field_types.push_back(CREDIT_CARD_NUMBER);
   test::CreateTestFormField("Month", "card_month", "", "text", &field);
@@ skipping 51 matching lines @@
   test::CreateTestFormField("Month", "card_month", "", "text", &field);
   form.fields.push_back(field);
   field_types.push_back(CREDIT_CARD_EXP_MONTH);
   test::CreateTestFormField("Year", "card_year", "", "text", &field);
   form.fields.push_back(field);
   field_types.push_back(CREDIT_CARD_EXP_2_DIGIT_YEAR);
   test::CreateTestFormField("Credit card", "card", "", "text", &field);
   form.fields.push_back(field);
   field_types.push_back(CREDIT_CARD_NUMBER);
 
-  // Simulate having seen this form on page load.
-  autofill_manager_->AddSeenForm(form, field_types, field_types);
+  {
+    // Simulate having seen this insecure form on page load.
+    form.origin = GURL("http://example.com/form.html");
+    form.action = GURL("http://example.com/submit.html");
+    autofill_manager_->AddSeenForm(form, field_types, field_types);
+
+    // Simulate an Autofill query on a credit card field (HTTP, non-secure
+    // form).
+    base::HistogramTester histogram_tester;
+    autofill_manager_->OnQueryFormFieldAutofill(0, form, form.fields[1],
+                                                gfx::RectF());
+    histogram_tester.ExpectUniqueSample(
+        "Autofill.QueriedCreditCardFormIsSecure", false, 1);
+  }
 
   {
-    // Simulate an Autofill query on a credit card field.
-    autofill_client_.set_is_context_secure(true);
+    // Simulate having seen this secure form on page load.
+    autofill_manager_->Reset();
+    form.origin = GURL("https://example.com/form.html");
+    form.action = GURL("https://example.com/submit.html");
+    autofill_manager_->AddSeenForm(form, field_types, field_types);
+
+    // Simulate an Autofill query on a credit card field (HTTPS form).
     base::HistogramTester histogram_tester;
     autofill_manager_->OnQueryFormFieldAutofill(0, form, form.fields[1],
                                                 gfx::RectF());
     histogram_tester.ExpectUniqueSample(
         "Autofill.QueriedCreditCardFormIsSecure", true, 1);
   }
-
-  {
-    // Simulate an Autofill query on a credit card field.
-    autofill_client_.set_is_context_secure(false);
-    base::HistogramTester histogram_tester;
-    autofill_manager_->OnQueryFormFieldAutofill(0, form, form.fields[1],
-                                                gfx::RectF());
-    histogram_tester.ExpectUniqueSample(
-        "Autofill.QueriedCreditCardFormIsSecure", false, 1);
-  }
 }
 
 // Tests that the Autofill_PolledProfileSuggestions user action is only logged
 // once if the field is queried repeatedly.
 TEST_F(AutofillMetricsTest, PolledProfileSuggestions_DebounceLogs) {
   personal_data_->RecreateProfiles(true /* include_local_profile */,
                                    false /* include_server_profile */);
 
   // Set up the form data.
   FormData form;
@@ skipping 2194 matching lines @@
   EXPECT_THAT(
       histogram_tester.GetAllSamples("Autofill.ServerResponseHasDataForForm"),
       ElementsAre(Bucket(true, 2)));
 
   // No RAPPOR metrics are logged in the case there is at least some server data
   // available for all forms.
   EXPECT_EQ(0, rappor_service_.GetReportsCount());
 }
 
 }  // namespace autofill