components/autofill/core/browser/autofill_manager.cc - Issue 2419853002: [Autofill] Do not offer autofill suggestions on insecure forms

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/autofill_manager.cc

Issue 2419853002: [Autofill] Do not offer autofill suggestions on insecure forms (Closed)

Patch Set: Scheme check for HTTPS Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/autofill/core/browser/autofill_manager.cc

diff --git a/components/autofill/core/browser/autofill_manager.cc b/components/autofill/core/browser/autofill_manager.cc

index 505a629410c19b43d4d1a5af59dbeeda915c7fd7..bd2b3ff39ab4b0f03d331864ee22dd0cdc109417 100644

--- a/components/autofill/core/browser/autofill_manager.cc

+++ b/components/autofill/core/browser/autofill_manager.cc

@@ -552,7 +552,8 @@ void AutofillManager::OnQueryFormFieldAutofill(int query_id,

}

if (!suggestions.empty()) {

bool is_context_secure =

- client_->IsContextSecure(form_structure->source_url());

+ client_->IsContextSecure(form_structure->source_url()) &&

+ form_structure->target_url().SchemeIs("https");

if (is_filling_credit_card)

AutofillMetrics::LogIsQueriedCreditCardFormSecure(is_context_secure);