Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 2417893002: Remove use of deprecated base::ListValue::Append(Value*) overload in //chromeos. (Closed)

Created:
4 years, 2 months ago by dcheng
Modified:
4 years, 2 months ago
Reviewers:
stevenjb, Daniel Erat
CC:
chromium-reviews, alemate+watch_chromium.org, stevenjb+watch_chromium.org, oshima+watch_chromium.org, hashimoto+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove use of deprecated base::ListValue::Append(Value*) overload in //chromeos. BUG=581865 R=derat@chromium.org TBR=stevenjb@chromium.org Committed: https://crrev.com/01319808da87488e6b350b724fd33f8794d6af42 Cr-Commit-Position: refs/heads/master@{#425130}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -7 lines) Patch
M chromeos/dbus/fake_shill_manager_client.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chromeos/geolocation/simple_geolocation_request.cc View 3 chunks +5 lines, -2 lines 0 comments Download
M chromeos/network/managed_network_configuration_handler_impl.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 20 (12 generated)
dcheng
4 years, 2 months ago (2016-10-13 17:37:42 UTC) #3
Daniel Erat
lgtm
4 years, 2 months ago (2016-10-13 17:52:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2417893002/1
4 years, 2 months ago (2016-10-13 18:38:52 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/280587)
4 years, 2 months ago (2016-10-13 18:46:13 UTC) #11
dcheng
TBRing noparent network directory to stevenjb
4 years, 2 months ago (2016-10-13 19:40:10 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2417893002/1
4 years, 2 months ago (2016-10-13 19:40:45 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-13 19:45:41 UTC) #18
commit-bot: I haz the power
4 years, 2 months ago (2016-10-13 19:47:47 UTC) #20
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/01319808da87488e6b350b724fd33f8794d6af42
Cr-Commit-Position: refs/heads/master@{#425130}

Powered by Google App Engine
This is Rietveld 408576698