Remove use of deprecated base::ListValue::Append(Value*) overload in //chromeos.

chromeos/geolocation/simple_geolocation_request.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromeos/geolocation/simple_geolocation_request.h"
 
 #include <stddef.h>
 
 #include <algorithm>
 #include <string>
+#include <utility>
 
 #include "base/json/json_reader.h"
 #include "base/json/json_writer.h"
+#include "base/memory/ptr_util.h"
 #include "base/metrics/histogram_macros.h"
 #include "base/metrics/sparse_histogram.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/stringprintf.h"
 #include "base/time/time.h"
 #include "base/values.h"
 #include "chromeos/geolocation/simple_geolocation_provider.h"
 #include "chromeos/geolocation/simple_geolocation_request_test_monitor.h"
 #include "google_apis/google_api_keys.h"
 #include "net/base/escape.h"
@@ skipping 301 matching lines @@
     return std::string(kSimpleGeolocationRequestBody);
   }
 
   std::unique_ptr<base::DictionaryValue> request(new base::DictionaryValue);
   request->SetBooleanWithoutPathExpansion(kConsiderIp, true);
 
   base::ListValue* wifi_access_points(new base::ListValue);
   request->SetWithoutPathExpansion(kWifiAccessPoints, wifi_access_points);
 
   for (const WifiAccessPoint& access_point : *wifi_data_) {
-    base::DictionaryValue* access_point_dictionary = new base::DictionaryValue;
-    wifi_access_points->Append(access_point_dictionary);
+    auto access_point_dictionary = base::MakeUnique<base::DictionaryValue>();
 
     access_point_dictionary->SetStringWithoutPathExpansion(
         kMacAddress, access_point.mac_address);
     access_point_dictionary->SetIntegerWithoutPathExpansion(
         kSignalStrength, access_point.signal_strength);
     if (!access_point.timestamp.is_null()) {
       access_point_dictionary->SetStringWithoutPathExpansion(
           kAge,
           base::Int64ToString(
               (base::Time::Now() - access_point.timestamp).InMilliseconds()));
     }
 
     access_point_dictionary->SetIntegerWithoutPathExpansion(
         kChannel, access_point.channel);
     access_point_dictionary->SetIntegerWithoutPathExpansion(
         kSignalToNoiseRatio, access_point.signal_to_noise);
+
+    wifi_access_points->Append(std::move(access_point_dictionary));
   }
   std::string result;
   if (!base::JSONWriter::Write(*request, &result)) {
     ReportUmaHasWiFiAccessPoints(false);
     return std::string(kSimpleGeolocationRequestBody);
   }
   ReportUmaHasWiFiAccessPoints(wifi_data_->size());
 
   return result;
 }
@@ skipping 107 matching lines @@
            ? SIMPLE_GEOLOCATION_REQUEST_RESULT_SERVER_ERROR
            : SIMPLE_GEOLOCATION_REQUEST_RESULT_FAILURE);
   RecordUmaResult(result, retries_);
   position_.status = Geoposition::STATUS_TIMEOUT;
   const base::TimeDelta elapsed = base::Time::Now() - request_started_at_;
   ReplyAndDestroySelf(elapsed, true /* server_error */);
   // "this" is already destroyed here.
 }
 
 }  // namespace chromeos