Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Unified Diff: chromeos/dbus/fake_shill_manager_client.cc

Issue 2417893002: Remove use of deprecated base::ListValue::Append(Value*) overload in //chromeos. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chromeos/geolocation/simple_geolocation_request.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/dbus/fake_shill_manager_client.cc
diff --git a/chromeos/dbus/fake_shill_manager_client.cc b/chromeos/dbus/fake_shill_manager_client.cc
index 047c4f1ac10b0f93815e437ae287e68c0cbcad24..a4df88bfc4b77f60939d845e01853aa94b6aacff 100644
--- a/chromeos/dbus/fake_shill_manager_client.cc
+++ b/chromeos/dbus/fake_shill_manager_client.cc
@@ -457,7 +457,7 @@ void FakeShillManagerClient::AddGeoNetwork(
list_value = new base::ListValue;
stub_geo_networks_.SetWithoutPathExpansion(technology, list_value);
}
- list_value->Append(network.DeepCopy());
+ list_value->Append(network.CreateDeepCopy());
}
void FakeShillManagerClient::AddProfile(const std::string& profile_path) {
@@ -867,8 +867,8 @@ void FakeShillManagerClient::SetupDefaultEnvironment() {
services->SetServiceProperty(kCellularServicePath,
shill::kCellularLastGoodApnProperty, apn);
base::ListValue apn_list;
- apn_list.Append(apn.DeepCopy());
- apn_list.Append(apn2.DeepCopy());
+ apn_list.Append(apn.CreateDeepCopy());
+ apn_list.Append(apn2.CreateDeepCopy());
devices->SetDeviceProperty("/device/cellular1",
shill::kCellularApnListProperty, apn_list);
@@ -1041,7 +1041,7 @@ base::ListValue* FakeShillManagerClient::GetEnabledServiceList(
std::string type;
properties->GetString(shill::kTypeProperty, &type);
if (TechnologyEnabled(type))
- new_service_list->Append((*iter)->DeepCopy());
+ new_service_list->Append((*iter)->CreateDeepCopy());
}
}
return new_service_list;
« no previous file with comments | « no previous file | chromeos/geolocation/simple_geolocation_request.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698