Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Issue 2417773003: Fix content upside down when call OffscreenCanvas's commit (Closed)

Created:
4 years, 2 months ago by xidachen
Modified:
4 years, 2 months ago
CC:
chromium-reviews, f(malita), krit, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, Stephen Chennney, dshwang, jam, jbroman, Rik, darin-cc_chromium.org, pdr+graphicswatchlist_chromium.org, blink-reviews, piman+watch_chromium.org, kinuko+watch, ajuma+watch_chromium.org, danakj+watch_chromium.org, blink-worker-reviews_chromium.org, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix content upside down when call OffscreenCanvas's commit The reason that the content is upside down is that we have a flag called yflipped and it is always false. In the case of GPU compositing, this flag should be true. This CL also updates pixel tests for WebGL's commit, such that instead of drawing a uniform color square, we draw a white triangle on a green background. BUG=655333, 655311 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Committed: https://crrev.com/8ff3caa7df9850d82ade934e1415b6ff8cb43a6b Cr-Commit-Position: refs/heads/master@{#425571}

Patch Set 1 #

Patch Set 2 : minor change in the test page #

Patch Set 3 : label failure #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -23 lines) Patch
M content/test/data/gpu/pixel_offscreenCanvas_webgl_commit_main.html View 2 chunks +48 lines, -6 lines 0 comments Download
M content/test/data/gpu/pixel_offscreenCanvas_webgl_commit_worker.html View 1 2 2 chunks +48 lines, -6 lines 0 comments Download
M content/test/gpu/gpu_tests/pixel_expectations.py View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M content/test/gpu/gpu_tests/pixel_test_pages.py View 1 1 chunk +10 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.cpp View 1 2 3 4 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 20 (13 generated)
xidachen
PTAL Locally I have tested this patch on Linux, Win, Mac and android and they ...
4 years, 2 months ago (2016-10-13 15:04:31 UTC) #3
xlai (Olivia)
On 2016/10/13 15:04:31, xidachen wrote: > PTAL > > Locally I have tested this patch ...
4 years, 2 months ago (2016-10-13 15:43:45 UTC) #4
Justin Novosad
lgtm
4 years, 2 months ago (2016-10-13 21:52:43 UTC) #5
Zhenyao Mo
On 2016/10/13 21:52:43, Justin Novosad wrote: > lgtm lgtm
4 years, 2 months ago (2016-10-15 03:33:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2417773003/60001
4 years, 2 months ago (2016-10-15 19:10:57 UTC) #17
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 2 months ago (2016-10-15 19:17:08 UTC) #18
commit-bot: I haz the power
4 years, 2 months ago (2016-10-15 19:20:22 UTC) #20
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/8ff3caa7df9850d82ade934e1415b6ff8cb43a6b
Cr-Commit-Position: refs/heads/master@{#425571}

Powered by Google App Engine
This is Rietveld 408576698