Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(779)

Issue 2418623002: [Devtools] Added divider timing to network timeline expirement (Closed)

Created:
4 years, 2 months ago by allada
Modified:
4 years, 2 months ago
Reviewers:
dgozman, lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Devtools] Added divider timing to network timeline expirement see: http://imgur.com/a/uIiLF R=lushnikov,dgozman BUG=653738 Committed: https://crrev.com/c9c071af6a05b6bb7ada87177ce2c0da568533bc Cr-Commit-Position: refs/heads/master@{#425400}

Patch Set 1 : [Devtools] Added divider timeing to network timeline expirement #

Total comments: 1

Patch Set 2 : Merge branch 'NETWORK_TIMELINE_5_HOVER' into NETWORK_TIMELINE_6_DRAW_DIVIDERS #

Patch Set 3 : Merge branch 'master' into NETWORK_TIMELINE_6_DRAW_DIVIDERS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -1 line) Patch
M third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js View 1 chunk +47 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui_lazy/TimelineGrid.js View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 26 (16 generated)
allada
PTL https://codereview.chromium.org/2418623002/diff/20001/third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js File third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js (right): https://codereview.chromium.org/2418623002/diff/20001/third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js#newcode255 third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js:255: _drawDividers: function(context) This function is to replace: https://cs.chromium.org/chromium/src/third_party/WebKit/Source/devtools/front_end/ui_lazy/TimelineGrid.js?l=56
4 years, 2 months ago (2016-10-12 20:47:09 UTC) #2
allada
https://codereview.chromium.org/2418623002/diff/40001/third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js File third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js (right): https://codereview.chromium.org/2418623002/diff/40001/third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js#newcode255 third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js:255: _drawDividers: function(context) This function is to replace: https://cs.chromium.org/chromium/src/third_party/WebKit/Source/devtools/front_end/ui_lazy/TimelineGrid.js?l=56
4 years, 2 months ago (2016-10-12 21:02:56 UTC) #4
dgozman
lgtm
4 years, 2 months ago (2016-10-13 22:56:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2418623002/60001
4 years, 2 months ago (2016-10-14 02:23:00 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/86519)
4 years, 2 months ago (2016-10-14 02:25:00 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2418623002/60001
4 years, 2 months ago (2016-10-14 16:54:23 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/286433) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 2 months ago (2016-10-14 16:57:24 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2418623002/80001
4 years, 2 months ago (2016-10-14 17:13:15 UTC) #22
commit-bot: I haz the power
Committed patchset #3 (id:80001)
4 years, 2 months ago (2016-10-14 18:42:37 UTC) #24
commit-bot: I haz the power
4 years, 2 months ago (2016-10-14 18:45:24 UTC) #26
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c9c071af6a05b6bb7ada87177ce2c0da568533bc
Cr-Commit-Position: refs/heads/master@{#425400}

Powered by Google App Engine
This is Rietveld 408576698