Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2416953002: Improve gpu pixel tests for OffscreenCanvas 2d (Closed)

Created:
4 years, 2 months ago by xlai (Olivia)
Modified:
4 years, 2 months ago
Reviewers:
xidachen, Zhenyao Mo
CC:
chromium-reviews, jam, kinuko+watch, darin-cc_chromium.org, blink-worker-reviews_chromium.org, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Improve gpu pixel tests for OffscreenCanvas 2d BUG=655311 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Committed: https://crrev.com/f30364de462f0a655b33085a1404cd445feb46e2 Cr-Commit-Position: refs/heads/master@{#425776}

Patch Set 1 #

Patch Set 2 : point to the correct bug #

Total comments: 4

Patch Set 3 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -23 lines) Patch
M content/test/data/gpu/pixel_offscreenCanvas_2d_commit_main.html View 1 2 3 chunks +13 lines, -7 lines 0 comments Download
M content/test/data/gpu/pixel_offscreenCanvas_2d_commit_worker.html View 1 2 3 chunks +10 lines, -4 lines 0 comments Download
M content/test/gpu/gpu_tests/pixel_expectations.py View 1 1 chunk +8 lines, -0 lines 0 comments Download
M content/test/gpu/gpu_tests/pixel_test_pages.py View 1 chunk +12 lines, -12 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
xlai (Olivia)
4 years, 2 months ago (2016-10-13 15:46:58 UTC) #3
xidachen
https://codereview.chromium.org/2416953002/diff/20001/content/test/data/gpu/pixel_offscreenCanvas_2d_commit_main.html File content/test/data/gpu/pixel_offscreenCanvas_2d_commit_main.html (right): https://codereview.chromium.org/2416953002/diff/20001/content/test/data/gpu/pixel_offscreenCanvas_2d_commit_main.html#newcode34 content/test/data/gpu/pixel_offscreenCanvas_2d_commit_main.html:34: offscreen2d.fillRect(100, 0, 200, 100); I think the last two ...
4 years, 2 months ago (2016-10-13 17:07:51 UTC) #4
xlai (Olivia)
https://codereview.chromium.org/2416953002/diff/20001/content/test/data/gpu/pixel_offscreenCanvas_2d_commit_main.html File content/test/data/gpu/pixel_offscreenCanvas_2d_commit_main.html (right): https://codereview.chromium.org/2416953002/diff/20001/content/test/data/gpu/pixel_offscreenCanvas_2d_commit_main.html#newcode34 content/test/data/gpu/pixel_offscreenCanvas_2d_commit_main.html:34: offscreen2d.fillRect(100, 0, 200, 100); On 2016/10/13 17:07:50, xidachen wrote: ...
4 years, 2 months ago (2016-10-13 18:48:24 UTC) #5
xidachen
non-owner lgtm
4 years, 2 months ago (2016-10-13 18:50:57 UTC) #6
xlai (Olivia)
gentle ping to zmo@
4 years, 2 months ago (2016-10-17 14:47:30 UTC) #7
Zhenyao Mo
On 2016/10/17 14:47:30, xlai (Olivia) wrote: > gentle ping to zmo@ lgtm
4 years, 2 months ago (2016-10-17 17:46:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2416953002/40001
4 years, 2 months ago (2016-10-17 18:28:02 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-17 21:04:24 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-17 21:06:44 UTC) #13
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/f30364de462f0a655b33085a1404cd445feb46e2
Cr-Commit-Position: refs/heads/master@{#425776}

Powered by Google App Engine
This is Rietveld 408576698