Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: src/asmjs/asm-types.h

Issue 2416243002: Make unittests work in component build (Closed)
Patch Set: updates Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/allocation.h ('k') | src/asmjs/switch-logic.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/asmjs/asm-types.h
diff --git a/src/asmjs/asm-types.h b/src/asmjs/asm-types.h
index 6fe42013c02f866266fc207926b4948899a940db..388572df938df4491030cc37fbfbb8d88252208c 100644
--- a/src/asmjs/asm-types.h
+++ b/src/asmjs/asm-types.h
@@ -7,7 +7,9 @@
#include <string>
+#include "src/base/compiler-specific.h"
#include "src/base/macros.h"
+#include "src/globals.h"
#include "src/zone/zone-containers.h"
#include "src/zone/zone.h"
@@ -101,7 +103,7 @@ class AsmValueType {
DISALLOW_IMPLICIT_CONSTRUCTORS(AsmValueType);
};
-class AsmCallableType : public ZoneObject {
+class V8_EXPORT_PRIVATE AsmCallableType : public NON_EXPORTED_BASE(ZoneObject) {
public:
virtual std::string Name() = 0;
@@ -124,7 +126,7 @@ class AsmCallableType : public ZoneObject {
DISALLOW_COPY_AND_ASSIGN(AsmCallableType);
};
-class AsmFunctionType final : public AsmCallableType {
+class V8_EXPORT_PRIVATE AsmFunctionType final : public AsmCallableType {
public:
AsmFunctionType* AsFunctionType() final { return this; }
@@ -151,7 +153,8 @@ class AsmFunctionType final : public AsmCallableType {
DISALLOW_COPY_AND_ASSIGN(AsmFunctionType);
};
-class AsmOverloadedFunctionType final : public AsmCallableType {
+class V8_EXPORT_PRIVATE AsmOverloadedFunctionType final
+ : public AsmCallableType {
public:
AsmOverloadedFunctionType* AsOverloadedFunctionType() override {
return this;
@@ -173,7 +176,7 @@ class AsmOverloadedFunctionType final : public AsmCallableType {
DISALLOW_IMPLICIT_CONSTRUCTORS(AsmOverloadedFunctionType);
};
-class AsmFFIType final : public AsmCallableType {
+class V8_EXPORT_PRIVATE AsmFFIType final : public AsmCallableType {
public:
AsmFFIType* AsFFIType() override { return this; }
@@ -189,7 +192,7 @@ class AsmFFIType final : public AsmCallableType {
DISALLOW_COPY_AND_ASSIGN(AsmFFIType);
};
-class AsmFunctionTableType : public AsmCallableType {
+class V8_EXPORT_PRIVATE AsmFunctionTableType : public AsmCallableType {
public:
AsmFunctionTableType* AsFunctionTableType() override { return this; }
@@ -212,7 +215,7 @@ class AsmFunctionTableType : public AsmCallableType {
DISALLOW_IMPLICIT_CONSTRUCTORS(AsmFunctionTableType);
};
-class AsmType {
+class V8_EXPORT_PRIVATE AsmType {
public:
#define DEFINE_CONSTRUCTOR(CamelName, string_name, number, parent_types) \
static AsmType* CamelName() { \
« no previous file with comments | « src/allocation.h ('k') | src/asmjs/switch-logic.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698