Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(899)

Issue 2416143003: Remove is_debug from enable_webvr flag (N SDK is now available!) (Closed)

Created:
4 years, 2 months ago by bshe
Modified:
4 years, 1 month ago
Reviewers:
brettw
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove is_debug from enable_webvr flag (N SDK is now available!) Also add comment about why is_component_build check is necessary BUG=389343 Committed: https://crrev.com/ffb586400bdf276af3a94bf95b5790a0afdc8f31 Cr-Commit-Position: refs/heads/master@{#430844}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M build/config/features.gni View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 15 (9 generated)
bshe
Hi Brett. Do you mind to take a look at this CL? I have verified ...
4 years, 2 months ago (2016-10-14 23:28:27 UTC) #3
brettw
lgtm
4 years, 2 months ago (2016-10-15 05:29:16 UTC) #4
bshe
On 2016/10/15 05:29:16, brettw (ping on IM after 24h) wrote: > lgtm Thanks! It looks ...
4 years, 2 months ago (2016-10-17 12:40:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2416143003/1
4 years, 1 month ago (2016-11-09 01:07:06 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-09 03:25:49 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-09 03:28:57 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ffb586400bdf276af3a94bf95b5790a0afdc8f31
Cr-Commit-Position: refs/heads/master@{#430844}

Powered by Google App Engine
This is Rietveld 408576698