Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Side by Side Diff: build/config/features.gni

Issue 2416143003: Remove is_debug from enable_webvr flag (N SDK is now available!) (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # ============================================= 5 # =============================================
6 # PLEASE DO NOT ADD MORE FLAGS TO THIS FILE 6 # PLEASE DO NOT ADD MORE FLAGS TO THIS FILE
7 # ============================================= 7 # =============================================
8 # 8 #
9 # These flags are effectively global. Your feature flag should go near the 9 # These flags are effectively global. Your feature flag should go near the
10 # code it controls. Most of these items are here now because they control 10 # code it controls. Most of these items are here now because they control
(...skipping 87 matching lines...) Expand 10 before | Expand all | Expand 10 after
98 98
99 # Enable printing with print preview. It does not imply 99 # Enable printing with print preview. It does not imply
100 # enable_basic_printing. It's possible to build Chrome with preview only. 100 # enable_basic_printing. It's possible to build Chrome with preview only.
101 enable_print_preview = !is_android && !is_chromecast && !is_ios 101 enable_print_preview = !is_android && !is_chromecast && !is_ios
102 102
103 # Whether or not to use external popup menu. 103 # Whether or not to use external popup menu.
104 use_external_popup_menu = is_android || is_mac 104 use_external_popup_menu = is_android || is_mac
105 105
106 # Enable WebVR support by default on Android 106 # Enable WebVR support by default on Android
107 # Still requires command line flag to access API 107 # Still requires command line flag to access API
108 enable_webvr = is_android && is_component_build && is_debug && 108 # TODO(bshe): Remove is_component_build once we can statically link gvr
109 # library. Currently gvr library only has a prebuild so file which causes
110 # linking issue for non component build.
111 enable_webvr = is_android && is_component_build &&
109 (current_cpu == "x86" || current_cpu == "x64" || 112 (current_cpu == "x86" || current_cpu == "x64" ||
110 current_cpu == "arm" || current_cpu == "arm64") 113 current_cpu == "arm" || current_cpu == "arm64")
111 } 114 }
112 115
113 # Additional dependent variables ----------------------------------------------- 116 # Additional dependent variables -----------------------------------------------
114 117
115 # Enable the spell checker. 118 # Enable the spell checker.
116 enable_spellcheck = !is_ios 119 enable_spellcheck = !is_ios
117 120
118 # Use the operating system's spellchecker rather than hunspell. 121 # Use the operating system's spellchecker rather than hunspell.
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
156 159
157 enable_configuration_policy = !is_ios 160 enable_configuration_policy = !is_ios
158 161
159 enable_mac_keystone = is_mac && is_chrome_branded && is_official_build 162 enable_mac_keystone = is_mac && is_chrome_branded && is_official_build
160 # 163 #
161 # ============================================= 164 # =============================================
162 # PLEASE DO NOT ADD MORE FLAGS TO THIS FILE 165 # PLEASE DO NOT ADD MORE FLAGS TO THIS FILE
163 # ============================================= 166 # =============================================
164 # 167 #
165 # See comment at the top. 168 # See comment at the top.
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698