Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Unified Diff: build/config/features.gni

Issue 2416143003: Remove is_debug from enable_webvr flag (N SDK is now available!) (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/features.gni
diff --git a/build/config/features.gni b/build/config/features.gni
index 304fafcd9139a3d327babe0194bf58a38a09b870..883e57056cd7683b51ababd33a8376548cce3639 100644
--- a/build/config/features.gni
+++ b/build/config/features.gni
@@ -105,7 +105,10 @@ declare_args() {
# Enable WebVR support by default on Android
# Still requires command line flag to access API
- enable_webvr = is_android && is_component_build && is_debug &&
+ # TODO(bshe): Remove is_component_build once we can statically link gvr
+ # library. Currently gvr library only has a prebuild so file which causes
+ # linking issue for non component build.
+ enable_webvr = is_android && is_component_build &&
(current_cpu == "x86" || current_cpu == "x64" ||
current_cpu == "arm" || current_cpu == "arm64")
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698