Fixed the behaviour of form submit to match the standard: no submit is taken place when the form is…

Fixed the behaviour of form submit to match the standard: no submit is taken place when the form is detached from the document (e.g., form is removed).

One additional layout test (form-removed-from-document.html) is added to verify the change made above.

Two layout tests has been modified to match the behaviour of submitting form (when from is detached from/attached to the document) in Firefox.

BUG=586749
Committed: https://crrev.com/962c2a22ddc474255c776aefc7abeba00edc7470
Cr-Commit-Position: refs/heads/master@{#425734}

[lunalu1, 2016-10-13 19:11:10]

The CQ bit was checked by lunalu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-13 19:11:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lunalu1, 2016-10-13 20:06:49]

lunalu@chromium.org changed reviewers:
+ tkent@chromium.org

[lunalu1, 2016-10-13 20:06:49]

Hi, 

I would like to reland this CL with a new test-case added.

Could you please take a look at it.

Thanks

[commit-bot: I haz the power, 2016-10-13 20:41:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-13 20:41:10]

Dry run: This issue passed the CQ dry run.

[tkent, 2016-10-13 22:19:06]

https://codereview.chromium.org/2416033002/diff/10007/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/HTMLFormElement.cpp (right):

https://codereview.chromium.org/2416033002/diff/10007/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/HTMLFormElement.cpp:355: return;
Let's show a console warning in order to notice what's wrong to a web developer.

[lunalu1, 2016-10-14 15:08:45]

Done. Thanks

https://codereview.chromium.org/2416033002/diff/10007/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/HTMLFormElement.cpp (right):

https://codereview.chromium.org/2416033002/diff/10007/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/HTMLFormElement.cpp:355: return;
On 2016/10/13 22:19:06, tkent wrote:
> Let's show a console warning in order to notice what's wrong to a web
developer.
> 

Done.

[lunalu1, 2016-10-14 15:11:42]

The CQ bit was checked by lunalu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-14 15:12:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tkent, 2016-10-14 15:16:35]

lgtm

[commit-bot: I haz the power, 2016-10-14 17:38:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-14 17:38:18]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[lunalu1, 2016-10-14 18:46:09]

lunalu@chromium.org changed reviewers:
+ ojan@chromium.org

[lunalu1, 2016-10-14 18:46:09]

Hi ojan,

I modified two layout tests you created as I changed the form submit behaviour.

Could you please take a look at the change and confirm that this the test
results are still as expected?

Thanks

[lunalu1, 2016-10-14 18:46:21]

The CQ bit was checked by lunalu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-14 18:46:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ojan, 2016-10-14 21:09:20]

The layout test changes lgtm. Have you verified that this fixed the cloud print
problem?

[commit-bot: I haz the power, 2016-10-14 22:09:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-14 22:09:39]

Dry run: This issue passed the CQ dry run.

[lunalu1, 2016-10-17 14:28:20]

The CQ bit was checked by lunalu@chromium.org

[lunalu1, 2016-10-17 14:28:21]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org
Link to the patchset: https://codereview.chromium.org/2416033002/#ps50001
(title: "Modified layout tests for the new behaviour")

[commit-bot: I haz the power, 2016-10-17 14:28:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-17 14:41:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-17 14:41:33]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[lunalu1, 2016-10-17 14:51:11]

lunalu@chromium.org changed reviewers:
+ ericwilligers@chromium.org

[lunalu1, 2016-10-17 14:51:12]

Hi ericwilligers

I made some changes in the histograms.xml file. Could you please take a look at
it so that I can commit this CL?

Thanks
Luna

[Eric Willigers, 2016-10-17 18:43:31]

The CQ bit was checked by ericwilligers@chromium.org

[Eric Willigers, 2016-10-17 18:43:31]

lgtm

[commit-bot: I haz the power, 2016-10-17 18:44:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-17 18:50:11]

Committed patchset #4 (id:50001)

[commit-bot: I haz the power, 2016-10-17 18:51:39]

Description was changed from

==========
Fixed the behaviour of form submit to match the standard: no submit is taken
place when the form is detached from the document (e.g., form is removed).

One additional layout test (form-removed-from-document.html) is added to verify
the change made above.

Two layout tests has been modified to match the behaviour of submitting form
(when from is detached from/attached to the document) in Firefox.

BUG=586749
==========

to

==========
Fixed the behaviour of form submit to match the standard: no submit is taken
place when the form is detached from the document (e.g., form is removed).

One additional layout test (form-removed-from-document.html) is added to verify
the change made above.

Two layout tests has been modified to match the behaviour of submitting form
(when from is detached from/attached to the document) in Firefox.

BUG=586749

Committed: https://crrev.com/962c2a22ddc474255c776aefc7abeba00edc7470
Cr-Commit-Position: refs/heads/master@{#425734}
==========

[commit-bot: I haz the power, 2016-10-17 18:51:40]

Patchset 4 (id:??) landed as
https://crrev.com/962c2a22ddc474255c776aefc7abeba00edc7470
Cr-Commit-Position: refs/heads/master@{#425734}