third_party/WebKit/LayoutTests/fast/forms/form-submission-crash-successful-submit-button.html - Issue 2416033002: Fixed the behaviour of form submit to match the standard: no submit is taken place when the form is…

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/forms/form-submission-crash-successful-submit-button.html

Issue 2416033002: Fixed the behaviour of form submit to match the standard: no submit is taken place when the form is… (Closed)

Patch Set: Modified layout tests for the new behaviour Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/forms/form-submission-crash.html ('k') | third_party/WebKit/LayoutTests/fast/forms/submit-form-not-attached-to-document.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <body>	2 <body>

3 <script src="../../resources/js-test.js"></script>	3 <script src="../../resources/js-test.js"></script>

4 <script>	4 <script>

5 jsTestIsAsync = true;	5 jsTestIsAsync = true;

6 var form1;	6 var form1;

7 var submit1;	7 var submit1;

8	8

9 function start() {	9 function start() {

10 form1 = document.createElement('form');	10 form1 = document.createElement('form');

11 submit1 = document.createElement('input');	11 submit1 = document.createElement('input');

12 submit2 = document.createElement('input');	12 submit2 = document.createElement('input');

13 submit1.type = 'submit';	13 submit1.type = 'submit';

14 submit2.type = 'image';	14 submit2.type = 'image';

15 form1.addEventListener('submit', handleSubmit, false);	15 form1.addEventListener('submit', handleSubmit, false);

16 form1.action = 'javascript:removeImage()';	16 form1.action = 'javascript:removeImage()';

17 form1.appendChild(submit1);	17 form1.appendChild(submit1);

18 form1.appendChild(submit2);	18 form1.appendChild(submit2);

	19 document.body.appendChild(form1);

19 submit1.click();	20 submit1.click();

20 testPassed('if not crashed.');	21 testPassed('if not crashed.');

21 finishJSTest();	22 finishJSTest();

22 }	23 }

23	24

24 function handleSubmit() {	25 function handleSubmit() {

25 form1.removeChild(submit1);	26 form1.removeChild(submit1);

26 }	27 }

27	28

28 function removeImage() {	29 function removeImage() {

29 form1.removeChild(submit2);	30 form1.removeChild(submit2);

30 submit2 = null;	31 submit2 = null;

31 gc();	32 gc();

32 }	33 }

33	34

34 window.onload = start;	35 window.onload = start;

35 </script>	36 </script>

36 </body>	37 </body>

OLD	NEW