Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 2414043003: Only log Tabs.CountAtStartup for Tabbed mode. (Closed)

Created:
4 years, 2 months ago by Ted C
Modified:
4 years, 2 months ago
Reviewers:
Yusuf
CC:
chromium-reviews, lizeb+watch-custom-tabs_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Only log Tabs.CountAtStartup for Tabbed mode. After https://codereview.chromium.org/2336413002, CCTs now trigger loadState, which will pollute this metric with CCT numbers. BUG= Committed: https://crrev.com/fd645569e0187569ab2b67ace21742b949c4b596 Cr-Commit-Position: refs/heads/master@{#425194}

Patch Set 1 #

Messages

Total messages: 8 (3 generated)
Ted C
PTAL
4 years, 2 months ago (2016-10-13 18:53:09 UTC) #2
Yusuf
lgtm
4 years, 2 months ago (2016-10-13 21:26:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2414043003/1
4 years, 2 months ago (2016-10-13 21:29:04 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-13 22:32:53 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-13 22:35:17 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fd645569e0187569ab2b67ace21742b949c4b596
Cr-Commit-Position: refs/heads/master@{#425194}

Powered by Google App Engine
This is Rietveld 408576698