Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4080)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabPersistentStore.java

Issue 2414043003: Only log Tabs.CountAtStartup for Tabbed mode. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabPersistentStore.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabPersistentStore.java b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabPersistentStore.java
index 12c23366e2af7904fc8ac49fc54259a5bbc7b8f3..9f95debf884fe33ee9f77d7265247cb8d432b10d 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabPersistentStore.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabPersistentStore.java
@@ -102,35 +102,35 @@ public class TabPersistentStore extends TabPersister {
/**
* Alerted at various stages of operation.
*/
- public static interface TabPersistentStoreObserver {
+ public abstract static class TabPersistentStoreObserver {
/**
* To be called when the file containing the initial information about the TabModels has
* been loaded.
* @param tabCountAtStartup How many tabs there are in the TabModels.
*/
- void onInitialized(int tabCountAtStartup);
+ void onInitialized(int tabCountAtStartup) {}
/**
* Called when details about a Tab are read from the metadata file.
*/
void onDetailsRead(int index, int id, String url,
- boolean isStandardActiveIndex, boolean isIncognitoActiveIndex);
+ boolean isStandardActiveIndex, boolean isIncognitoActiveIndex) {}
/**
* To be called when the TabStates have all been loaded.
*/
- void onStateLoaded();
+ void onStateLoaded() {}
/**
* To be called when the TabState from another instance has been merged.
*/
- void onStateMerged();
+ void onStateMerged() {}
/**
* Called when the metadata file has been saved out asynchronously.
* This currently does not get called when the metadata file is saved out on the UI thread.
*/
- void onMetadataSavedAsynchronously();
+ void onMetadataSavedAsynchronously() {}
}
/** Stores information about a TabModel. */
@@ -399,6 +399,7 @@ public class TabPersistentStore extends TabPersister {
Log.d(TAG, "loadState exception: " + e.toString(), e);
}
+ mPersistencePolicy.notifyStateLoaded(mTabsToRestore.size());
if (mObserver != null) mObserver.onInitialized(mTabsToRestore.size());
}

Powered by Google App Engine
This is Rietveld 408576698