Actually enable tab persistence for CCTs.

Actually enable tab persistence for CCTs.

TEST=Actually use the feature.
     Turn on "Don't keep activities", leave a CCT, click on
     it from recents.  See that your final page is visible.
BUG=606513
Committed: https://crrev.com/426df5c8550a7a7a9623240bd46ba054817a7572
Cr-Commit-Position: refs/heads/master@{#418727}

[Ted C, 2016-09-14 00:27:01]

tedchoc@chromium.org changed reviewers:
+ dfalcantara@chromium.org, yusufo@chromium.org

[Ted C, 2016-09-14 00:27:02]

PTAL

[Yusuf, 2016-09-14 18:20:51]

https://codereview.chromium.org/2336413002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java
(right):

https://codereview.chromium.org/2336413002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java:311:
assert mMainTab == null;
if we have run warmup and early tab initialization, we will actually have
mMainTab non null at this point with it already loading the url that was in the
intent.

Maybe we should move this to createMainTab as an early intervention there? That
way both finishNativeInitialization and preInflationStartup calls would get it.

https://codereview.chromium.org/2336413002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java:626:
mIsClosing = true;
I wonder if we can just use isDestroyed here? Are we worried about onDestroy
calling time and finish calling time not playing nice with each other?

[Ted C, 2016-09-14 20:29:12]

https://codereview.chromium.org/2336413002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java
(right):

https://codereview.chromium.org/2336413002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java:311:
assert mMainTab == null;
On 2016/09/14 18:20:51, Yusuf wrote:
> if we have run warmup and early tab initialization, we will actually have
> mMainTab non null at this point with it already loading the url that was in
the
> intent.
> 
> Maybe we should move this to createMainTab as an early intervention there?
That
> way both finishNativeInitialization and preInflationStartup calls would get
it.

Per the offline discussion, I think it is better to not create a tab early if we
are restoring state.  Since you're refocusing from recents, it is very unlikely
that the warmup will be caused by the underlying app, so I don't think it's
worth the complexity to support it.

https://codereview.chromium.org/2336413002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java:626:
mIsClosing = true;
On 2016/09/14 18:20:51, Yusuf wrote:
> I wonder if we can just use isDestroyed here? Are we worried about onDestroy
> calling time and finish calling time not playing nice with each other?

We wouldn't be destroyed at this point, so I think we need to track this
separately.

[Yusuf, 2016-09-14 21:10:13]

lgtm

[gone, 2016-09-14 23:22:40]

lgtm

[Ted C, 2016-09-15 00:04:02]

The CQ bit was checked by tedchoc@chromium.org

[Ted C, 2016-09-15 00:04:03]

The patchset sent to the CQ was uploaded after l-g-t-m from yusufo@chromium.org
Link to the patchset: https://chromiumcodereview.appspot.com/2336413002/#ps40001
(title: "Move tab model observer before tab creation")

[commit-bot: I haz the power, 2016-09-15 00:04:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 00:38:23]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-15 00:40:14]

Description was changed from

==========
Actually enable tab persistence for CCTs.

TEST=Actually use the feature.
     Turn on "Don't keep activities", leave a CCT, click on
     it from recents.  See that your final page is visible.
BUG=606513
==========

to

==========
Actually enable tab persistence for CCTs.

TEST=Actually use the feature.
     Turn on "Don't keep activities", leave a CCT, click on
     it from recents.  See that your final page is visible.
BUG=606513

Committed: https://crrev.com/426df5c8550a7a7a9623240bd46ba054817a7572
Cr-Commit-Position: refs/heads/master@{#418727}
==========

[commit-bot: I haz the power, 2016-09-15 00:40:15]

Patchset 3 (id:??) landed as
https://crrev.com/426df5c8550a7a7a9623240bd46ba054817a7572
Cr-Commit-Position: refs/heads/master@{#418727}