 Chromium Code Reviews
 Chromium Code Reviews Issue 24139004:
  Add toWebCoreString() / toWebCoreAtomicString() overloads taking a v8::String  (Closed) 
  Base URL: svn://svn.chromium.org/blink/trunk
    
  
    Issue 24139004:
  Add toWebCoreString() / toWebCoreAtomicString() overloads taking a v8::String  (Closed) 
  Base URL: svn://svn.chromium.org/blink/trunk| Index: Source/bindings/v8/ScriptEventListener.cpp | 
| diff --git a/Source/bindings/v8/ScriptEventListener.cpp b/Source/bindings/v8/ScriptEventListener.cpp | 
| index 035802ab42306b9ee6b50c8763b570c39c0830fd..03b4788bdf850821b8edf6cc8d5b99c64cb7658f 100644 | 
| --- a/Source/bindings/v8/ScriptEventListener.cpp | 
| +++ b/Source/bindings/v8/ScriptEventListener.cpp | 
| @@ -98,7 +98,7 @@ String eventListenerHandlerBody(Document* document, EventListener* listener) | 
| V8AbstractEventListener* v8Listener = static_cast<V8AbstractEventListener*>(listener); | 
| v8::Handle<v8::Context> context = toV8Context(document, v8Listener->world()); | 
| v8::Context::Scope contextScope(context); | 
| - v8::Handle<v8::Object> function = v8Listener->getListenerObject(document); | 
| + v8::Handle<v8::Value> function = v8Listener->getListenerObject(document); | 
| if (function.IsEmpty()) | 
| return ""; | 
| @@ -148,7 +148,7 @@ bool eventListenerHandlerLocation(Document* document, EventListener* listener, S | 
| scriptId = toWebCoreStringWithUndefinedOrNullCheck(scriptIdValue); | 
| v8::ScriptOrigin origin = function->GetScriptOrigin(); | 
| if (origin.ResourceName()->IsString() && !origin.ResourceName().IsEmpty()) | 
| 
haraken
2013/09/16 12:06:48
Not related to your CL, this check looks silly. We
 
do-not-use
2013/09/16 12:10:30
Right. I'll fix this before landing.
 | 
| - sourceName = toWebCoreString(origin.ResourceName()); | 
| + sourceName = toWebCoreString(origin.ResourceName().As<v8::String>()); | 
| else | 
| sourceName = ""; | 
| lineNumber = function->GetScriptLineNumber(); |