Source/bindings/v8/IDBBindingUtilities.cpp - Issue 24139004: Add toWebCoreString() / toWebCoreAtomicString() overloads taking a v8::String

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/IDBBindingUtilities.cpp

Issue 24139004: Add toWebCoreString() / toWebCoreAtomicString() overloads taking a v8::String (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/v8/IDBBindingUtilities.cpp

diff --git a/Source/bindings/v8/IDBBindingUtilities.cpp b/Source/bindings/v8/IDBBindingUtilities.cpp

index 111453eca34027969fb6772a12e51a4a9ae74687..325304b546d257c08b45ae252bb89c70d6265b40 100644

--- a/Source/bindings/v8/IDBBindingUtilities.cpp

+++ b/Source/bindings/v8/IDBBindingUtilities.cpp

@@ -79,7 +79,7 @@ static PassRefPtr<IDBKey> createIDBKeyFromValue(v8::Handle<v8::Value> value, Vec

if (value->IsNumber() && !std::isnan(value->NumberValue()))

return IDBKey::createNumber(value->NumberValue());

if (value->IsString())

- return IDBKey::createString(toWebCoreString(value));

+ return IDBKey::createString(toWebCoreString(value.As<v8::String>()));

if (value->IsDate() && !std::isnan(value->NumberValue()))

return IDBKey::createDate(value->NumberValue());

if (value->IsArray()) {

« no previous file with comments | « no previous file | Source/bindings/v8/ScriptEventListener.cpp » ('j') | Source/bindings/v8/ScriptEventListener.cpp » ('J')