Add toWebCoreString() / toWebCoreAtomicString() overloads taking a v8::String

Source/bindings/v8/ScriptEventListener.cpp

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 80 matching lines @@
 
 String eventListenerHandlerBody(Document* document, EventListener* listener)
 {
     if (listener->type() != EventListener::JSEventListenerType)
         return "";
 
     v8::HandleScope scope(isolateForScriptExecutionContext(document));
     V8AbstractEventListener* v8Listener = static_cast<V8AbstractEventListener*>(listener);
     v8::Handle<v8::Context> context = toV8Context(document, v8Listener->world());
     v8::Context::Scope contextScope(context);
-    v8::Handle<v8::Object> function = v8Listener->getListenerObject(document);
+    v8::Handle<v8::Value> function = v8Listener->getListenerObject(document);
     if (function.IsEmpty())
         return "";
 
     return toWebCoreStringWithNullCheck(function);
 }
 
 ScriptValue eventListenerHandler(Document* document, EventListener* listener)
 {
     if (listener->type() != EventListener::JSEventListenerType)
         return ScriptValue();
@@ skipping 28 matching lines @@
     v8::Handle<v8::Context> context = toV8Context(document, v8Listener->world());
     v8::Context::Scope contextScope(context);
     v8::Handle<v8::Object> object = v8Listener->getListenerObject(document);
     if (object.IsEmpty() || !object->IsFunction())
         return false;
 
     v8::Handle<v8::Function> function = v8::Handle<v8::Function>::Cast(object);
     v8::Handle<v8::Value> scriptIdValue = function->GetScriptId();
     scriptId = toWebCoreStringWithUndefinedOrNullCheck(scriptIdValue);
     v8::ScriptOrigin origin = function->GetScriptOrigin();
     if (origin.ResourceName()->IsString() && !origin.ResourceName().IsEmpty())

[haraken, 2013/09/16 12:06:48]

Not related to your CL, this check looks silly. We have to first check
.IsEmpty() and then ->IsString().

[do-not-use, 2013/09/16 12:10:30]

Right. I'll fix this before landing.

-        sourceName = toWebCoreString(origin.ResourceName());
+        sourceName = toWebCoreString(origin.ResourceName().As<v8::String>());
     else
         sourceName = "";
     lineNumber = function->GetScriptLineNumber();
     return true;
 }
 
 } // namespace WebCore