Add browser tests for NavigationPreload.

Add browser tests for NavigationPreload.

This CL depends on https://codereview.chromium.org/2416843002/

FetchEvent.navigationPreload will be implemented in the following steps.
[1/4] Introduce FetchEventPreloadHandle to pass the preload response to FetchEvent.
      https://codereview.chromium.org/2417793002/
[2/4] Implement ServiceWorkerFetchDispatcher::MaybeStartNavigationPreload().
      https://codereview.chromium.org/2410333006/
[3/4] Implement FetchEvent.navigationPreload.
      https://codereview.chromium.org/2416843002/
[4/4] Add browser tests for NavigationPreload.
      https://codereview.chromium.org/2413643005/ This CL.

Currently NavigationPreloadManager.enable() API is not implemented yet.
So in those tests, we sets this flag by directly calling ServiceWorkerVersion.
set_navigation_preload_enabled()

BUG=649558
R=falken@chromium.org

Committed: https://crrev.com/84814befc09874e372a5aec52c1553c9dd519797
Cr-Commit-Position: refs/heads/master@{#427705}

[horo, 2016-10-13 09:36:39]

Description was changed from

==========
Add browser tests for NavigationPreload.

This CL depends on https://codereview.chromium.org/2416843002/

BUG=649558
==========

to

==========
Add browser tests for NavigationPreload.

This CL depends on https://codereview.chromium.org/2416843002/

FetchEvent.navigationPreload will be implemented in the following steps.
[1/4] Introduce FetchEventPreloadHandle to pass the preload response to
FetchEvent.
      https://codereview.chromium.org/2417793002/
[2/4] Implement ServiceWorkerFetchDispatcher::MaybeStartNavigationPreload().
      https://codereview.chromium.org/2410333006/
[3/4] Implement FetchEvent.navigationPreload.
      https://codereview.chromium.org/2416843002/
[4/4] Add browser tests for NavigationPreload.
      https://codereview.chromium.org/2413643005/ This CL.

Currently NavigationPreloadManager.enable() API is not implemented yet.
So in those tests, we sets this flag by directly calling ServiceWorkerVersion.
set_navigation_preload_enabled()

BUG=649558
==========

[horo, 2016-10-14 10:19:25]

Patchset #3 (id:40001) has been deleted

[horo, 2016-10-15 03:45:29]

The CQ bit was checked by horo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-15 03:45:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-15 04:21:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-15 04:21:46]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[horo, 2016-10-15 04:49:53]

The CQ bit was checked by horo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-15 04:50:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[horo, 2016-10-15 05:06:48]

Patchset #5 (id:100001) has been deleted

[horo, 2016-10-15 05:06:55]

The CQ bit was checked by horo@chromium.org to run a CQ dry run

[horo, 2016-10-15 05:07:02]

Patchset #5 (id:100001) has been deleted

[commit-bot: I haz the power, 2016-10-15 05:07:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-15 05:50:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-15 05:50:58]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[horo, 2016-10-15 06:30:57]

The CQ bit was checked by horo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-15 06:31:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-15 07:50:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-15 07:50:23]

Dry run: Exceeded global retry quota

[horo, 2016-10-17 05:28:24]

The CQ bit was checked by horo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-17 05:28:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-17 06:49:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-17 06:49:20]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[horo, 2016-10-19 04:22:41]

Patchset #8 (id:180001) has been deleted

[horo, 2016-10-19 04:22:45]

Patchset #7 (id:160001) has been deleted

[horo, 2016-10-19 04:22:48]

Patchset #6 (id:140001) has been deleted

[horo, 2016-10-19 04:22:51]

Patchset #5 (id:120001) has been deleted

[horo, 2016-10-19 04:22:55]

Patchset #4 (id:80001) has been deleted

[horo, 2016-10-19 04:22:58]

Patchset #3 (id:60001) has been deleted

[horo, 2016-10-19 04:23:01]

Patchset #2 (id:20001) has been deleted

[horo, 2016-10-19 04:23:03]

Patchset #1 (id:1) has been deleted

[horo, 2016-10-19 04:23:19]

The CQ bit was checked by horo@chromium.org to run a CQ dry run

[horo, 2016-10-19 04:24:54]

horo@chromium.org changed reviewers:
+ falken@chromium.org

[horo, 2016-10-19 04:24:54]

falken@
Could you please review this?

[commit-bot: I haz the power, 2016-10-19 04:25:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-19 09:53:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-19 09:53:56]

Dry run: Exceeded global retry quota

[horo, 2016-10-20 07:16:18]

The CQ bit was checked by horo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-20 07:16:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[falken, 2016-10-20 08:17:40]

lgtm. nice thorough tests. looks great.

https://codereview.chromium.org/2413643005/diff/200001/content/browser/servic...
File content/browser/service_worker/service_worker_browsertest.cc (right):

https://codereview.chromium.org/2413643005/diff/200001/content/browser/servic...
content/browser/service_worker/service_worker_browsertest.cc:1575: "           
'    {port: channel.port2}, [channel.port2]);\\n' +\n"
nit: No need to send an object with {port:}, transferring [channel.port2] sets
MessageEvent.ports[0] automatically.

https://codereview.chromium.org/2413643005/diff/200001/content/browser/servic...
content/browser/service_worker/service_worker_browsertest.cc:1582: "           
result => event.data.port.postMessage(result)));\n"
This can just be event.ports[0].postMessage

https://codereview.chromium.org/2413643005/diff/200001/content/browser/servic...
content/browser/service_worker/service_worker_browsertest.cc:1606: // The page
request must be sent twice.
As the comment repeats the code, it could explain why: once for navigation
preload, and once for fallback since respondWith wasn't used.

https://codereview.chromium.org/2413643005/diff/200001/content/browser/servic...
content/browser/service_worker/service_worker_browsertest.cc:1641: // The page
request must be sent only once.
since the worker responded with the navigation preload response

https://codereview.chromium.org/2413643005/diff/200001/content/browser/servic...
content/browser/service_worker/service_worker_browsertest.cc:1674: // The page
request must be sent only once.
since the worker responded with "Hello world"

https://codereview.chromium.org/2413643005/diff/200001/content/browser/servic...
content/browser/service_worker/service_worker_browsertest.cc:1707: "           
'    {port: channel.port2}, [channel.port2]);\\n' +\n"
ditto with port passing

[commit-bot: I haz the power, 2016-10-20 10:29:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-20 10:29:07]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[horo, 2016-10-20 14:04:35]

The CQ bit was checked by horo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-20 14:04:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[horo, 2016-10-20 14:05:34]

Thank you.

https://chromiumcodereview.appspot.com/2413643005/diff/200001/content/browser...
File content/browser/service_worker/service_worker_browsertest.cc (right):

https://chromiumcodereview.appspot.com/2413643005/diff/200001/content/browser...
content/browser/service_worker/service_worker_browsertest.cc:1575: "           
'    {port: channel.port2}, [channel.port2]);\\n' +\n"
On 2016/10/20 08:17:40, falken (ooo Oct 21) wrote:
> nit: No need to send an object with {port:}, transferring [channel.port2] sets
> MessageEvent.ports[0] automatically.

Done.

https://chromiumcodereview.appspot.com/2413643005/diff/200001/content/browser...
content/browser/service_worker/service_worker_browsertest.cc:1582: "           
result => event.data.port.postMessage(result)));\n"
On 2016/10/20 08:17:39, falken (ooo Oct 21) wrote:
> This can just be event.ports[0].postMessage

Done.

https://chromiumcodereview.appspot.com/2413643005/diff/200001/content/browser...
content/browser/service_worker/service_worker_browsertest.cc:1606: // The page
request must be sent twice.
On 2016/10/20 08:17:40, falken (ooo Oct 21) wrote:
> As the comment repeats the code, it could explain why: once for navigation
> preload, and once for fallback since respondWith wasn't used.

Done.

https://chromiumcodereview.appspot.com/2413643005/diff/200001/content/browser...
content/browser/service_worker/service_worker_browsertest.cc:1641: // The page
request must be sent only once.
On 2016/10/20 08:17:40, falken (ooo Oct 21) wrote:
> since the worker responded with the navigation preload response

Done.

https://chromiumcodereview.appspot.com/2413643005/diff/200001/content/browser...
content/browser/service_worker/service_worker_browsertest.cc:1674: // The page
request must be sent only once.
On 2016/10/20 08:17:40, falken (ooo Oct 21) wrote:
> since the worker responded with "Hello world"

Done.

https://chromiumcodereview.appspot.com/2413643005/diff/200001/content/browser...
content/browser/service_worker/service_worker_browsertest.cc:1707: "           
'    {port: channel.port2}, [channel.port2]);\\n' +\n"
On 2016/10/20 08:17:40, falken (ooo Oct 21) wrote:
> ditto with port passing

Done.

[commit-bot: I haz the power, 2016-10-20 17:55:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-20 17:55:59]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[horo, 2016-10-25 06:12:20]

The CQ bit was checked by horo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-25 06:12:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[horo, 2016-10-25 06:24:09]

Patchset #4 (id:260001) has been deleted

[horo, 2016-10-25 06:24:51]

The CQ bit was checked by horo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-25 06:25:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[horo, 2016-10-25 08:55:34]

Patchset #4 (id:280001) has been deleted

[horo, 2016-10-25 08:55:57]

The CQ bit was unchecked by horo@chromium.org

[horo, 2016-10-25 09:54:49]

The CQ bit was checked by horo@chromium.org

[horo, 2016-10-25 09:54:50]

The patchset sent to the CQ was uploaded after l-g-t-m from falken@chromium.org
Link to the patchset: https://codereview.chromium.org/2413643005/#ps240001
(title: "incorporated falken's comment")

[commit-bot: I haz the power, 2016-10-25 09:55:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 11:44:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-25 11:44:20]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[horo, 2016-10-25 12:01:40]

The CQ bit was checked by horo@chromium.org

[commit-bot: I haz the power, 2016-10-25 12:01:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 13:40:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-25 13:40:10]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[horo, 2016-10-26 02:17:52]

The CQ bit was checked by horo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 02:18:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 02:20:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 02:20:58]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[horo, 2016-10-26 02:30:05]

The CQ bit was checked by horo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 02:30:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[horo, 2016-10-26 03:18:30]

As I talked offline, I added
"-ServiceWorkerBrowserTest/ServiceWorkerNavigationPreloadTest.*" to
browser-side-navigation.linux.content_browsertests.filter to avoid the test
failure on browser_side_navigation_content_browsertests.

I will create a CL to support NavigationPreload with PlzNavigate.

[horo, 2016-10-26 03:18:37]

The CQ bit was unchecked by horo@chromium.org

[horo, 2016-10-26 03:18:46]

The CQ bit was checked by horo@chromium.org

[horo, 2016-10-26 03:18:46]

The patchset sent to the CQ was uploaded after l-g-t-m from falken@chromium.org
Link to the patchset: https://codereview.chromium.org/2413643005/#ps300001
(title: "browser-side-navigation.linux.content_browsertests.filter")

[commit-bot: I haz the power, 2016-10-26 03:19:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 04:16:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 04:16:39]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[horo, 2016-10-26 04:27:52]

The CQ bit was checked by horo@chromium.org

[commit-bot: I haz the power, 2016-10-26 04:28:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 06:44:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 06:44:08]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[horo, 2016-10-26 06:50:23]

The CQ bit was checked by horo@chromium.org

[commit-bot: I haz the power, 2016-10-26 06:50:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 09:32:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 09:32:16]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[horo, 2016-10-26 09:40:51]

The CQ bit was checked by horo@chromium.org

[commit-bot: I haz the power, 2016-10-26 09:41:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 12:17:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 12:17:33]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[horo, 2016-10-26 12:52:30]

The CQ bit was checked by horo@chromium.org

[commit-bot: I haz the power, 2016-10-26 12:52:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[horo, 2016-10-26 15:35:12]

The CQ bit was unchecked by horo@chromium.org

[horo, 2016-10-26 15:35:48]

The CQ bit was checked by horo@chromium.org

[commit-bot: I haz the power, 2016-10-26 15:36:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[horo, 2016-10-26 16:19:18]

Description was changed from

==========
Add browser tests for NavigationPreload.

This CL depends on https://codereview.chromium.org/2416843002/

FetchEvent.navigationPreload will be implemented in the following steps.
[1/4] Introduce FetchEventPreloadHandle to pass the preload response to
FetchEvent.
      https://codereview.chromium.org/2417793002/
[2/4] Implement ServiceWorkerFetchDispatcher::MaybeStartNavigationPreload().
      https://codereview.chromium.org/2410333006/
[3/4] Implement FetchEvent.navigationPreload.
      https://codereview.chromium.org/2416843002/
[4/4] Add browser tests for NavigationPreload.
      https://codereview.chromium.org/2413643005/ This CL.

Currently NavigationPreloadManager.enable() API is not implemented yet.
So in those tests, we sets this flag by directly calling ServiceWorkerVersion.
set_navigation_preload_enabled()

BUG=649558
==========

to

==========
Add browser tests for NavigationPreload.

This CL depends on https://codereview.chromium.org/2416843002/

FetchEvent.navigationPreload will be implemented in the following steps.
[1/4] Introduce FetchEventPreloadHandle to pass the preload response to
FetchEvent.
      https://codereview.chromium.org/2417793002/
[2/4] Implement ServiceWorkerFetchDispatcher::MaybeStartNavigationPreload().
      https://codereview.chromium.org/2410333006/
[3/4] Implement FetchEvent.navigationPreload.
      https://codereview.chromium.org/2416843002/
[4/4] Add browser tests for NavigationPreload.
      https://codereview.chromium.org/2413643005/ This CL.

Currently NavigationPreloadManager.enable() API is not implemented yet.
So in those tests, we sets this flag by directly calling ServiceWorkerVersion.
set_navigation_preload_enabled()

BUG=649558
R=falken@chromium.org

Committed:
https://chromium.googlesource.com/chromium/src/+/84814befc09874e372a5aec52c15...
==========

[horo, 2016-10-26 16:19:21]

Committed patchset #4 (id:300001) manually as
84814befc09874e372a5aec52c1553c9dd519797 (presubmit successful).

[commit-bot: I haz the power, 2016-10-26 17:12:19]

Description was changed from

==========
Add browser tests for NavigationPreload.

This CL depends on https://codereview.chromium.org/2416843002/

FetchEvent.navigationPreload will be implemented in the following steps.
[1/4] Introduce FetchEventPreloadHandle to pass the preload response to
FetchEvent.
      https://codereview.chromium.org/2417793002/
[2/4] Implement ServiceWorkerFetchDispatcher::MaybeStartNavigationPreload().
      https://codereview.chromium.org/2410333006/
[3/4] Implement FetchEvent.navigationPreload.
      https://codereview.chromium.org/2416843002/
[4/4] Add browser tests for NavigationPreload.
      https://codereview.chromium.org/2413643005/ This CL.

Currently NavigationPreloadManager.enable() API is not implemented yet.
So in those tests, we sets this flag by directly calling ServiceWorkerVersion.
set_navigation_preload_enabled()

BUG=649558
R=falken@chromium.org

Committed:
https://chromium.googlesource.com/chromium/src/+/84814befc09874e372a5aec52c15...
==========

to

==========
Add browser tests for NavigationPreload.

This CL depends on https://codereview.chromium.org/2416843002/

FetchEvent.navigationPreload will be implemented in the following steps.
[1/4] Introduce FetchEventPreloadHandle to pass the preload response to
FetchEvent.
      https://codereview.chromium.org/2417793002/
[2/4] Implement ServiceWorkerFetchDispatcher::MaybeStartNavigationPreload().
      https://codereview.chromium.org/2410333006/
[3/4] Implement FetchEvent.navigationPreload.
      https://codereview.chromium.org/2416843002/
[4/4] Add browser tests for NavigationPreload.
      https://codereview.chromium.org/2413643005/ This CL.

Currently NavigationPreloadManager.enable() API is not implemented yet.
So in those tests, we sets this flag by directly calling ServiceWorkerVersion.
set_navigation_preload_enabled()

BUG=649558
R=falken@chromium.org

Committed: https://crrev.com/84814befc09874e372a5aec52c1553c9dd519797
Cr-Commit-Position: refs/heads/master@{#427705}
==========