Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2446083002:
Add ServiceWorkerNavigationPreloadTest for resolving navigationPreload with null. (Closed)
|
Created:
4 years, 1 month ago by horo Modified:
4 years, 1 month ago Reviewers:
falken CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, shimazu+serviceworker_chromium.org, serviceworker-reviews, jam, nhiroki, kinuko+serviceworker, horo+watch_chromium.org, darin-cc_chromium.org, kinuko+watch, tzik, blink-worker-reviews_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd ServiceWorkerNavigationPreloadTest for resolving navigationPreload with null.
At the discussion in https://crrev.com/2416843002/#msg62, I decided not to use
the nullable promise type. So when navigation preload is not enabled,
FetchEvent.navigationPreload must return a promise which will be resolved with
null.
This CL adds a test for this behavior.
BUG=649558
Committed: https://crrev.com/1514cecaef424f0eea432275857b6e2031642da0
Cr-Commit-Position: refs/heads/master@{#427745}
Patch Set 1 #
Depends on Patchset: Messages
Total messages: 24 (18 generated)
Patchset #1 (id:1) has been deleted
Description was changed from ========== Add ServiceWorkerNavigationPreloadTest for resolve navigationPreload with null BUG=649558 ========== to ========== Add ServiceWorkerNavigationPreloadTest for resolve navigationPreload with null At the discussion in https://crrev.com/2416843002/#msg62, I decided not to use the nullable promise type. So when navigation preload is not enabled, FetchEvent.navigationPreload must return a promise which will be resolved with null. This CL adds a test for this behavior. BUG=649558 ==========
Patchset #1 (id:20001) has been deleted
Description was changed from ========== Add ServiceWorkerNavigationPreloadTest for resolve navigationPreload with null At the discussion in https://crrev.com/2416843002/#msg62, I decided not to use the nullable promise type. So when navigation preload is not enabled, FetchEvent.navigationPreload must return a promise which will be resolved with null. This CL adds a test for this behavior. BUG=649558 ========== to ========== Add ServiceWorkerNavigationPreloadTest for resolve navigationPreload with null. At the discussion in https://crrev.com/2416843002/#msg62, I decided not to use the nullable promise type. So when navigation preload is not enabled, FetchEvent.navigationPreload must return a promise which will be resolved with null. This CL adds a test for this behavior. BUG=649558 ==========
The CQ bit was checked by horo@chromium.org to run a CQ dry run
Description was changed from ========== Add ServiceWorkerNavigationPreloadTest for resolve navigationPreload with null. At the discussion in https://crrev.com/2416843002/#msg62, I decided not to use the nullable promise type. So when navigation preload is not enabled, FetchEvent.navigationPreload must return a promise which will be resolved with null. This CL adds a test for this behavior. BUG=649558 ========== to ========== Add ServiceWorkerNavigationPreloadTest for resolving navigationPreload with null. At the discussion in https://crrev.com/2416843002/#msg62, I decided not to use the nullable promise type. So when navigation preload is not enabled, FetchEvent.navigationPreload must return a promise which will be resolved with null. This CL adds a test for this behavior. BUG=649558 ==========
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
horo@chromium.org changed reviewers: + falken@chromium.org
falken@ Please review this.
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by falken@chromium.org
The CQ bit was unchecked by falken@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
This CL has an open dependency (Issue 2413643005 Patch 300001). Please resolve the dependency and try again. If you are sure that there is no real dependency, please use one of the options listed in https://goo.gl/9Es4OR to land the CL.
The CQ bit was checked by horo@chromium.org
The CQ bit was unchecked by horo@chromium.org
The CQ bit was checked by horo@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Add ServiceWorkerNavigationPreloadTest for resolving navigationPreload with null. At the discussion in https://crrev.com/2416843002/#msg62, I decided not to use the nullable promise type. So when navigation preload is not enabled, FetchEvent.navigationPreload must return a promise which will be resolved with null. This CL adds a test for this behavior. BUG=649558 ========== to ========== Add ServiceWorkerNavigationPreloadTest for resolving navigationPreload with null. At the discussion in https://crrev.com/2416843002/#msg62, I decided not to use the nullable promise type. So when navigation preload is not enabled, FetchEvent.navigationPreload must return a promise which will be resolved with null. This CL adds a test for this behavior. BUG=649558 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Add ServiceWorkerNavigationPreloadTest for resolving navigationPreload with null. At the discussion in https://crrev.com/2416843002/#msg62, I decided not to use the nullable promise type. So when navigation preload is not enabled, FetchEvent.navigationPreload must return a promise which will be resolved with null. This CL adds a test for this behavior. BUG=649558 ========== to ========== Add ServiceWorkerNavigationPreloadTest for resolving navigationPreload with null. At the discussion in https://crrev.com/2416843002/#msg62, I decided not to use the nullable promise type. So when navigation preload is not enabled, FetchEvent.navigationPreload must return a promise which will be resolved with null. This CL adds a test for this behavior. BUG=649558 Committed: https://crrev.com/1514cecaef424f0eea432275857b6e2031642da0 Cr-Commit-Position: refs/heads/master@{#427745} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/1514cecaef424f0eea432275857b6e2031642da0 Cr-Commit-Position: refs/heads/master@{#427745} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
