Add BluetoothDevice.uuids attribute removal date in the deprecation string

Add BluetoothDevice.uuids attribute removal date in the deprecation string

This CL adds the removal date in the deprecation string for the
BluetoothDevice.uuids attribute.

BUG=653317
Committed: https://crrev.com/6da1894febdd92cc6308fd75af89c336b244e2da
Cr-Commit-Position: refs/heads/master@{#425181}

[juncai, 2016-10-12 22:14:44]

The CQ bit was checked by juncai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-12 22:15:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[juncai, 2016-10-12 22:16:49]

juncai@chromium.org changed reviewers:
+ dcheng@chromium.org

[juncai, 2016-10-12 22:16:50]

Please take a look. Thanks!

[commit-bot: I haz the power, 2016-10-12 23:48:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-12 23:48:11]

Dry run: This issue passed the CQ dry run.

[dcheng, 2016-10-13 04:43:33]

https://codereview.chromium.org/2412753003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/frame/Deprecation.cpp (right):

https://codereview.chromium.org/2412753003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/Deprecation.cpp:465: return String::format(
Can this use replacedBy("BluetoothDevice.uuids", M57, "getPrimaryServices()")?

[juncai, 2016-10-13 18:22:07]

https://codereview.chromium.org/2412753003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/frame/Deprecation.cpp (right):

https://codereview.chromium.org/2412753003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/Deprecation.cpp:465: return String::format(
On 2016/10/13 04:43:33, dcheng wrote:
> Can this use replacedBy("BluetoothDevice.uuids", M57, "getPrimaryServices()")?

The replacedBy() takes two parameters instead of three:
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/frame/Dep...
So the removal date can not be added.

[dcheng, 2016-10-13 20:13:37]

https://codereview.chromium.org/2412753003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/frame/Deprecation.cpp (right):

https://codereview.chromium.org/2412753003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/Deprecation.cpp:465: return String::format(
On 2016/10/13 18:22:07, juncai wrote:
> On 2016/10/13 04:43:33, dcheng wrote:
> > Can this use replacedBy("BluetoothDevice.uuids", M57,
"getPrimaryServices()")?
> 
> The replacedBy() takes two parameters instead of three:
>
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/frame/Dep...
> So the removal date can not be added.

Oops, sorry, I meant willBeRemoved(): does that make sense here?

[juncai, 2016-10-13 21:01:08]

https://codereview.chromium.org/2412753003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/frame/Deprecation.cpp (right):

https://codereview.chromium.org/2412753003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/Deprecation.cpp:465: return String::format(
On 2016/10/13 20:13:37, dcheng wrote:
> On 2016/10/13 18:22:07, juncai wrote:
> > On 2016/10/13 04:43:33, dcheng wrote:
> > > Can this use replacedBy("BluetoothDevice.uuids", M57,
> "getPrimaryServices()")?
> > 
> > The replacedBy() takes two parameters instead of three:
> >
>
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/frame/Dep...
> > So the removal date can not be added.
> 
> Oops, sorry, I meant willBeRemoved(): does that make sense here?

As the comment at:
https://codereview.chromium.org/2408773003/
mentioned, we don't have a chromestatus link, so we can't use willBeRemoved()
either.

[Jeffrey Yasskin, 2016-10-13 21:04:34]

jyasskin@chromium.org changed reviewers:
+ jyasskin@chromium.org

[Jeffrey Yasskin, 2016-10-13 21:04:35]

https://codereview.chromium.org/2412753003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/frame/Deprecation.cpp (right):

https://codereview.chromium.org/2412753003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/Deprecation.cpp:465: return String::format(
On 2016/10/13 21:01:08, juncai wrote:
> On 2016/10/13 20:13:37, dcheng wrote:
> > On 2016/10/13 18:22:07, juncai wrote:
> > > On 2016/10/13 04:43:33, dcheng wrote:
> > > > Can this use replacedBy("BluetoothDevice.uuids", M57,
> > "getPrimaryServices()")?
> > > 
> > > The replacedBy() takes two parameters instead of three:
> > >
> >
>
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/frame/Dep...
> > > So the removal date can not be added.
> > 
> > Oops, sorry, I meant willBeRemoved(): does that make sense here?
> 
> As the comment at:
> https://codereview.chromium.org/2408773003/
> mentioned, we don't have a chromestatus link, so we can't use willBeRemoved()
> either.

Specifically, Web Bluetooth has a link at
https://www.chromestatus.com/features/5264933985976320, but the removal of
'uuids' doesn't. I don't think this removal needs a chromestatus link because
Web Bluetooth isn't shipped yet (it's in an origin trial), but it does make
using the standard helper functions more difficult. The reason to deprecate
instead of removing outright, despite not having shipped, is that sites are
using the API under the origin trial, and it's kind not to break them abruptly
if we don't have to.

[Jeffrey Yasskin, 2016-10-13 21:04:43]

Description was changed from

==========
Add BluetoothDevice.uuids attribute removal date in the deprecation string

This CL adds the removal date in the deprecation string for the
BluetoothDevice.uuids attribute.

BUG=653317
==========

to

==========
Add BluetoothDevice.uuids attribute removal date in the deprecation string

This CL adds the removal date in the deprecation string for the
BluetoothDevice.uuids attribute.

BUG=653317
==========

[Jeffrey Yasskin, 2016-10-13 21:04:44]

jyasskin@chromium.org changed reviewers:
- jyasskin@chromium.org

[dcheng, 2016-10-13 21:56:29]

lgtm

[juncai, 2016-10-13 22:00:50]

The CQ bit was checked by juncai@chromium.org

[commit-bot: I haz the power, 2016-10-13 22:01:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-13 22:08:24]

Description was changed from

==========
Add BluetoothDevice.uuids attribute removal date in the deprecation string

This CL adds the removal date in the deprecation string for the
BluetoothDevice.uuids attribute.

BUG=653317
==========

to

==========
Add BluetoothDevice.uuids attribute removal date in the deprecation string

This CL adds the removal date in the deprecation string for the
BluetoothDevice.uuids attribute.

BUG=653317
==========

[commit-bot: I haz the power, 2016-10-13 22:08:26]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-13 22:10:22]

Description was changed from

==========
Add BluetoothDevice.uuids attribute removal date in the deprecation string

This CL adds the removal date in the deprecation string for the
BluetoothDevice.uuids attribute.

BUG=653317
==========

to

==========
Add BluetoothDevice.uuids attribute removal date in the deprecation string

This CL adds the removal date in the deprecation string for the
BluetoothDevice.uuids attribute.

BUG=653317

Committed: https://crrev.com/6da1894febdd92cc6308fd75af89c336b244e2da
Cr-Commit-Position: refs/heads/master@{#425181}
==========

[commit-bot: I haz the power, 2016-10-13 22:10:23]

Patchset 1 (id:??) landed as
https://crrev.com/6da1894febdd92cc6308fd75af89c336b244e2da
Cr-Commit-Position: refs/heads/master@{#425181}