Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Side by Side Diff: third_party/WebKit/Source/core/frame/Deprecation.cpp

Issue 2412753003: Add BluetoothDevice.uuids attribute removal date in the deprecation string (Closed)
Patch Set: add BluetoothDevice.uuids attribute removal date in the deprecation string Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/frame/Deprecation.h" 5 #include "core/frame/Deprecation.h"
6 6
7 #include "core/dom/Document.h" 7 #include "core/dom/Document.h"
8 #include "core/dom/ExecutionContext.h" 8 #include "core/dom/ExecutionContext.h"
9 #include "core/frame/FrameConsole.h" 9 #include "core/frame/FrameConsole.h"
10 #include "core/frame/FrameHost.h" 10 #include "core/frame/FrameHost.h"
(...skipping 444 matching lines...) Expand 10 before | Expand all | Expand 10 after
455 return willBeRemoved("PaymentAddress.careOf", M56, "5728579069411328"); 455 return willBeRemoved("PaymentAddress.careOf", M56, "5728579069411328");
456 456
457 case UseCounter::VRDeprecatedFieldOfView: 457 case UseCounter::VRDeprecatedFieldOfView:
458 return replacedBy("VREyeParameters.fieldOfView", 458 return replacedBy("VREyeParameters.fieldOfView",
459 "projection matrices provided by VRFrameData"); 459 "projection matrices provided by VRFrameData");
460 460
461 case UseCounter::VRDeprecatedGetPose: 461 case UseCounter::VRDeprecatedGetPose:
462 return replacedBy("VRDisplay.getPose()", "VRDisplay.getFrameData()"); 462 return replacedBy("VRDisplay.getPose()", "VRDisplay.getFrameData()");
463 463
464 case UseCounter::DeprecatedBluetoothDeviceUUIDsAttribute: 464 case UseCounter::DeprecatedBluetoothDeviceUUIDsAttribute:
465 return "BluetoothDevice.uuids is deprecated. Use getPrimaryServices() to " 465 return String::format(
dcheng 2016/10/13 04:43:33 Can this use replacedBy("BluetoothDevice.uuids", M
juncai 2016/10/13 18:22:07 The replacedBy() takes two parameters instead of t
dcheng 2016/10/13 20:13:37 Oops, sorry, I meant willBeRemoved(): does that ma
juncai 2016/10/13 21:01:08 As the comment at: https://codereview.chromium.org
Jeffrey Yasskin 2016/10/13 21:04:34 Specifically, Web Bluetooth has a link at https://
466 "retrieve all available UUIDs."; 466 "BluetoothDevice.uuids is deprecated and will be removed in %s. Use "
467 "getPrimaryServices() to retrieve all available UUIDs.",
468 milestoneString(M57));
467 469
468 // Features that aren't deprecated don't have a deprecation message. 470 // Features that aren't deprecated don't have a deprecation message.
469 default: 471 default:
470 return String(); 472 return String();
471 } 473 }
472 } 474 }
473 475
474 } // namespace blink 476 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698