Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Unified Diff: third_party/WebKit/Source/core/frame/Deprecation.cpp

Issue 2412753003: Add BluetoothDevice.uuids attribute removal date in the deprecation string (Closed)
Patch Set: add BluetoothDevice.uuids attribute removal date in the deprecation string Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/frame/Deprecation.cpp
diff --git a/third_party/WebKit/Source/core/frame/Deprecation.cpp b/third_party/WebKit/Source/core/frame/Deprecation.cpp
index 4c0d973d8ffdc4786789901cb132dd1e26446ffa..86b92fb93a6ab78e3af975efb70d16720a4031ff 100644
--- a/third_party/WebKit/Source/core/frame/Deprecation.cpp
+++ b/third_party/WebKit/Source/core/frame/Deprecation.cpp
@@ -462,8 +462,10 @@ String Deprecation::deprecationMessage(UseCounter::Feature feature) {
return replacedBy("VRDisplay.getPose()", "VRDisplay.getFrameData()");
case UseCounter::DeprecatedBluetoothDeviceUUIDsAttribute:
- return "BluetoothDevice.uuids is deprecated. Use getPrimaryServices() to "
- "retrieve all available UUIDs.";
+ return String::format(
dcheng 2016/10/13 04:43:33 Can this use replacedBy("BluetoothDevice.uuids", M
juncai 2016/10/13 18:22:07 The replacedBy() takes two parameters instead of t
dcheng 2016/10/13 20:13:37 Oops, sorry, I meant willBeRemoved(): does that ma
juncai 2016/10/13 21:01:08 As the comment at: https://codereview.chromium.org
Jeffrey Yasskin 2016/10/13 21:04:34 Specifically, Web Bluetooth has a link at https://
+ "BluetoothDevice.uuids is deprecated and will be removed in %s. Use "
+ "getPrimaryServices() to retrieve all available UUIDs.",
+ milestoneString(M57));
// Features that aren't deprecated don't have a deprecation message.
default:
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698