Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Issue 2412563003: S390: Change printf format specifier for size_t in GcTracer (Closed)

Created:
4 years, 2 months ago by yangtian.zi
Modified:
4 years, 2 months ago
Reviewers:
Michael Lippautz, ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan, JoranSiu, john.yan, JaideepBajwa, michael_dawson, MTBrandyberry
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

S390: Change printf format specifier for size_t in GcTracer GCC on S390 31-bit treats size_t as 'long unsigned int', which is incompatible with %d format specifier that expects an 'int'. Using the appropriate macro (PRIuS) instead. R=mlippautz@chromium.org, ulan@chromium.org BUG= Committed: https://crrev.com/34e0596a39a5fc6bce89205c995c64764002237b Cr-Commit-Position: refs/heads/master@{#40276}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -14 lines) Patch
M src/heap/gc-tracer.cc View 2 chunks +14 lines, -14 lines 2 comments Download

Messages

Total messages: 12 (5 generated)
yangtian.zi
ptal
4 years, 2 months ago (2016-10-12 14:37:23 UTC) #2
ulan
Thanks for fixing. https://codereview.chromium.org/2412563003/diff/1/src/heap/gc-tracer.cc File src/heap/gc-tracer.cc (right): https://codereview.chromium.org/2412563003/diff/1/src/heap/gc-tracer.cc#newcode460 src/heap/gc-tracer.cc:460: "total_size_before=%" PRIuS Does %zu also work? ...
4 years, 2 months ago (2016-10-13 08:37:15 UTC) #3
yangtian.zi
https://codereview.chromium.org/2412563003/diff/1/src/heap/gc-tracer.cc File src/heap/gc-tracer.cc (right): https://codereview.chromium.org/2412563003/diff/1/src/heap/gc-tracer.cc#newcode460 src/heap/gc-tracer.cc:460: "total_size_before=%" PRIuS On 2016/10/13 08:37:14, ulan wrote: > Does ...
4 years, 2 months ago (2016-10-13 13:54:21 UTC) #4
ulan
LGTM.
4 years, 2 months ago (2016-10-13 14:05:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2412563003/1
4 years, 2 months ago (2016-10-13 14:12:41 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-13 14:56:04 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-13 14:56:23 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/34e0596a39a5fc6bce89205c995c64764002237b
Cr-Commit-Position: refs/heads/master@{#40276}

Powered by Google App Engine
This is Rietveld 408576698