 Chromium Code Reviews
 Chromium Code Reviews Issue 2412563003:
  S390: Change printf format specifier for size_t in GcTracer  (Closed)
    
  
    Issue 2412563003:
  S390: Change printf format specifier for size_t in GcTracer  (Closed) 
  | OLD | NEW | 
|---|---|
| 1 // Copyright 2014 the V8 project authors. All rights reserved. | 1 // Copyright 2014 the V8 project authors. All rights reserved. | 
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be | 
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. | 
| 4 | 4 | 
| 5 #include "src/heap/gc-tracer.h" | 5 #include "src/heap/gc-tracer.h" | 
| 6 | 6 | 
| 7 #include "src/counters.h" | 7 #include "src/counters.h" | 
| 8 #include "src/heap/heap-inl.h" | 8 #include "src/heap/heap-inl.h" | 
| 9 #include "src/isolate.h" | 9 #include "src/isolate.h" | 
| 10 | 10 | 
| (...skipping 439 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 450 "roots=%.2f " | 450 "roots=%.2f " | 
| 451 "code=%.2f " | 451 "code=%.2f " | 
| 452 "semispace=%.2f " | 452 "semispace=%.2f " | 
| 453 "object_groups=%.2f " | 453 "object_groups=%.2f " | 
| 454 "external_prologue=%.2f " | 454 "external_prologue=%.2f " | 
| 455 "external_epilogue=%.2f " | 455 "external_epilogue=%.2f " | 
| 456 "external_weak_global_handles=%.2f " | 456 "external_weak_global_handles=%.2f " | 
| 457 "steps_count=%d " | 457 "steps_count=%d " | 
| 458 "steps_took=%.1f " | 458 "steps_took=%.1f " | 
| 459 "scavenge_throughput=%.f " | 459 "scavenge_throughput=%.f " | 
| 460 "total_size_before=%" V8PRIdPTR | 460 "total_size_before=%" PRIuS | 
| 
ulan
2016/10/13 08:37:14
Does %zu also work? If so let's use it instead.
 
yangtian.zi
2016/10/13 13:54:21
The macro PRIuS stands for "zu" in POSIX systems,
 | |
| 461 " " | 461 " " | 
| 462 "total_size_after=%" V8PRIdPTR | 462 "total_size_after=%" PRIuS | 
| 463 " " | 463 " " | 
| 464 "holes_size_before=%" V8PRIdPTR | 464 "holes_size_before=%" PRIuS | 
| 465 " " | 465 " " | 
| 466 "holes_size_after=%" V8PRIdPTR | 466 "holes_size_after=%" PRIuS | 
| 467 " " | 467 " " | 
| 468 "allocated=%" V8PRIdPTR | 468 "allocated=%" PRIuS | 
| 469 " " | 469 " " | 
| 470 "promoted=%" V8PRIdPTR | 470 "promoted=%" PRIuS | 
| 471 " " | 471 " " | 
| 472 "semi_space_copied=%" V8PRIdPTR | 472 "semi_space_copied=%" PRIuS | 
| 473 " " | 473 " " | 
| 474 "nodes_died_in_new=%d " | 474 "nodes_died_in_new=%d " | 
| 475 "nodes_copied_in_new=%d " | 475 "nodes_copied_in_new=%d " | 
| 476 "nodes_promoted=%d " | 476 "nodes_promoted=%d " | 
| 477 "promotion_ratio=%.1f%% " | 477 "promotion_ratio=%.1f%% " | 
| 478 "average_survival_ratio=%.1f%% " | 478 "average_survival_ratio=%.1f%% " | 
| 479 "promotion_rate=%.1f%% " | 479 "promotion_rate=%.1f%% " | 
| 480 "semi_space_copy_rate=%.1f%% " | 480 "semi_space_copy_rate=%.1f%% " | 
| 481 "new_space_allocation_throughput=%.1f " | 481 "new_space_allocation_throughput=%.1f " | 
| 482 "context_disposal_rate=%.1f\n", | 482 "context_disposal_rate=%.1f\n", | 
| (...skipping 79 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 562 "incremental.sweeping=%.1f " | 562 "incremental.sweeping=%.1f " | 
| 563 "incremental.wrapper_prologue=%.1f " | 563 "incremental.wrapper_prologue=%.1f " | 
| 564 "incremental.wrapper_tracing=%.1f " | 564 "incremental.wrapper_tracing=%.1f " | 
| 565 "incremental_wrapper_tracing_longest_step=%.1f " | 565 "incremental_wrapper_tracing_longest_step=%.1f " | 
| 566 "incremental_finalize_longest_step=%.1f " | 566 "incremental_finalize_longest_step=%.1f " | 
| 567 "incremental_finalize_steps_count=%d " | 567 "incremental_finalize_steps_count=%d " | 
| 568 "incremental_longest_step=%.1f " | 568 "incremental_longest_step=%.1f " | 
| 569 "incremental_steps_count=%d " | 569 "incremental_steps_count=%d " | 
| 570 "incremental_marking_throughput=%.f " | 570 "incremental_marking_throughput=%.f " | 
| 571 "incremental_walltime_duration=%.f " | 571 "incremental_walltime_duration=%.f " | 
| 572 "total_size_before=%" V8PRIdPTR | 572 "total_size_before=%" PRIuS | 
| 573 " " | 573 " " | 
| 574 "total_size_after=%" V8PRIdPTR | 574 "total_size_after=%" PRIuS | 
| 575 " " | 575 " " | 
| 576 "holes_size_before=%" V8PRIdPTR | 576 "holes_size_before=%" PRIuS | 
| 577 " " | 577 " " | 
| 578 "holes_size_after=%" V8PRIdPTR | 578 "holes_size_after=%" PRIuS | 
| 579 " " | 579 " " | 
| 580 "allocated=%" V8PRIdPTR | 580 "allocated=%" PRIuS | 
| 581 " " | 581 " " | 
| 582 "promoted=%" V8PRIdPTR | 582 "promoted=%" PRIuS | 
| 583 " " | 583 " " | 
| 584 "semi_space_copied=%" V8PRIdPTR | 584 "semi_space_copied=%" PRIuS | 
| 585 " " | 585 " " | 
| 586 "nodes_died_in_new=%d " | 586 "nodes_died_in_new=%d " | 
| 587 "nodes_copied_in_new=%d " | 587 "nodes_copied_in_new=%d " | 
| 588 "nodes_promoted=%d " | 588 "nodes_promoted=%d " | 
| 589 "promotion_ratio=%.1f%% " | 589 "promotion_ratio=%.1f%% " | 
| 590 "average_survival_ratio=%.1f%% " | 590 "average_survival_ratio=%.1f%% " | 
| 591 "promotion_rate=%.1f%% " | 591 "promotion_rate=%.1f%% " | 
| 592 "semi_space_copy_rate=%.1f%% " | 592 "semi_space_copy_rate=%.1f%% " | 
| 593 "new_space_allocation_throughput=%.1f " | 593 "new_space_allocation_throughput=%.1f " | 
| 594 "context_disposal_rate=%.1f " | 594 "context_disposal_rate=%.1f " | 
| (...skipping 219 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 814 } | 814 } | 
| 815 | 815 | 
| 816 void GCTracer::ResetSurvivalEvents() { recorded_survival_ratios_.Reset(); } | 816 void GCTracer::ResetSurvivalEvents() { recorded_survival_ratios_.Reset(); } | 
| 817 | 817 | 
| 818 void GCTracer::NotifyIncrementalMarkingStart() { | 818 void GCTracer::NotifyIncrementalMarkingStart() { | 
| 819 incremental_marking_start_time_ = heap_->MonotonicallyIncreasingTimeInMs(); | 819 incremental_marking_start_time_ = heap_->MonotonicallyIncreasingTimeInMs(); | 
| 820 } | 820 } | 
| 821 | 821 | 
| 822 } // namespace internal | 822 } // namespace internal | 
| 823 } // namespace v8 | 823 } // namespace v8 | 
| OLD | NEW |