src/heap/gc-tracer.cc - Issue 2412563003: S390: Change printf format specifier for size_t in GcTracer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap/gc-tracer.cc

Issue 2412563003: S390: Change printf format specifier for size_t in GcTracer (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/heap/gc-tracer.cc

diff --git a/src/heap/gc-tracer.cc b/src/heap/gc-tracer.cc

index 2d93128e5e65af4df3fced7001355923fce576d8..5cfba6f7443d2c8081997aab4fa4e23b5a45d695 100644

--- a/src/heap/gc-tracer.cc

+++ b/src/heap/gc-tracer.cc

@@ -457,19 +457,19 @@ void GCTracer::PrintNVP() const {

"steps_count=%d "

"steps_took=%.1f "

"scavenge_throughput=%.f "

- "total_size_before=%" V8PRIdPTR

+ "total_size_before=%" PRIuS

ulan 2016/10/13 08:37:14 Does %zu also work? If so let's use it instead.

yangtian.zi 2016/10/13 13:54:21 The macro PRIuS stands for "zu" in POSIX systems,

" "

- "total_size_after=%" V8PRIdPTR

+ "total_size_after=%" PRIuS

" "

- "holes_size_before=%" V8PRIdPTR

+ "holes_size_before=%" PRIuS

" "

- "holes_size_after=%" V8PRIdPTR

+ "holes_size_after=%" PRIuS

" "

- "allocated=%" V8PRIdPTR

+ "allocated=%" PRIuS

" "

- "promoted=%" V8PRIdPTR

+ "promoted=%" PRIuS

" "

- "semi_space_copied=%" V8PRIdPTR

+ "semi_space_copied=%" PRIuS

" "

"nodes_died_in_new=%d "

"nodes_copied_in_new=%d "

@@ -569,19 +569,19 @@ void GCTracer::PrintNVP() const {

"incremental_steps_count=%d "

"incremental_marking_throughput=%.f "

"incremental_walltime_duration=%.f "