Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(491)

Issue 2412263002: [promises] rename PromiseContainer to PromiseResolveThenableJobInfo (Closed)

Created:
4 years, 2 months ago by gsathya
Modified:
4 years, 2 months ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[promises] rename PromiseContainer to PromiseResolveThenableJobInfo This is a much more descriptive name. BUG=v8:5343 TBR=bmeurer@chromium.org Committed: https://crrev.com/4fda85aa19f77d1b46dae83dc804c4a411420750 Cr-Commit-Position: refs/heads/master@{#40240}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : fix comment #

Patch Set 4 : fix build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -54 lines) Patch
M src/ast/ast-types.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/types.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/factory.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/factory.cc View 1 1 chunk +4 lines, -3 lines 0 comments Download
M src/isolate.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/isolate.cc View 1 2 3 4 chunks +19 lines, -17 lines 0 comments Download
M src/objects.h View 1 2 6 chunks +10 lines, -10 lines 0 comments Download
M src/objects-debug.cc View 1 1 chunk +11 lines, -8 lines 0 comments Download
M src/objects-inl.h View 1 1 chunk +8 lines, -6 lines 0 comments Download
M src/objects-printer.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M src/runtime/runtime-internal.cc View 1 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 25 (19 generated)
gsathya
4 years, 2 months ago (2016-10-12 21:09:48 UTC) #9
adamk
lgtm
4 years, 2 months ago (2016-10-12 21:59:01 UTC) #16
gsathya
On 2016/10/12 21:59:01, adamk wrote: > lgtm TBRing bmeurer since this is just editing an ...
4 years, 2 months ago (2016-10-12 22:16:37 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2412263002/60001
4 years, 2 months ago (2016-10-12 22:16:58 UTC) #21
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 2 months ago (2016-10-12 22:19:00 UTC) #23
commit-bot: I haz the power
4 years, 2 months ago (2016-10-12 22:19:19 UTC) #25
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/4fda85aa19f77d1b46dae83dc804c4a411420750
Cr-Commit-Position: refs/heads/master@{#40240}

Powered by Google App Engine
This is Rietveld 408576698