Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Unified Diff: src/isolate.cc

Issue 2412263002: [promises] rename PromiseContainer to PromiseResolveThenableJobInfo (Closed)
Patch Set: fix build Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/isolate.h ('k') | src/objects.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/isolate.cc
diff --git a/src/isolate.cc b/src/isolate.cc
index 2b9552b99d83f8f3432ca6349a4e901e16327a3f..792706dc71c54dc2de0bd5f992044004d26f2b46 100644
--- a/src/isolate.cc
+++ b/src/isolate.cc
@@ -3136,16 +3136,16 @@ void Isolate::PromiseReactionJob(Handle<PromiseReactionJobInfo> info,
}
}
-void Isolate::PromiseResolveThenableJob(Handle<PromiseContainer> container,
- MaybeHandle<Object>* result,
- MaybeHandle<Object>* maybe_exception) {
- PromiseDebugEventScope helper(this, container->before_debug_event(),
- container->after_debug_event());
-
- Handle<JSReceiver> thenable(container->thenable(), this);
- Handle<JSFunction> resolve(container->resolve(), this);
- Handle<JSFunction> reject(container->reject(), this);
- Handle<JSReceiver> then(container->then(), this);
+void Isolate::PromiseResolveThenableJob(
+ Handle<PromiseResolveThenableJobInfo> info, MaybeHandle<Object>* result,
+ MaybeHandle<Object>* maybe_exception) {
+ PromiseDebugEventScope helper(this, info->before_debug_event(),
+ info->after_debug_event());
+
+ Handle<JSReceiver> thenable(info->thenable(), this);
+ Handle<JSFunction> resolve(info->resolve(), this);
+ Handle<JSFunction> reject(info->reject(), this);
+ Handle<JSReceiver> then(info->then(), this);
Handle<Object> argv[] = {resolve, reject};
*result = Execution::TryCall(this, then, thenable, arraysize(argv), argv,
maybe_exception);
@@ -3162,7 +3162,7 @@ void Isolate::PromiseResolveThenableJob(Handle<PromiseContainer> container,
void Isolate::EnqueueMicrotask(Handle<Object> microtask) {
DCHECK(microtask->IsJSFunction() || microtask->IsCallHandlerInfo() ||
- microtask->IsPromiseContainer() ||
+ microtask->IsPromiseResolveThenableJobInfo() ||
microtask->IsPromiseReactionJobInfo());
Handle<FixedArray> queue(heap()->microtask_queue(), this);
int num_tasks = pending_microtask_count();
@@ -3218,9 +3218,10 @@ void Isolate::RunMicrotasksInternal() {
Context* context;
if (microtask->IsJSFunction()) {
context = Handle<JSFunction>::cast(microtask)->context();
- } else if (microtask->IsPromiseContainer()) {
- context =
- Handle<PromiseContainer>::cast(microtask)->resolve()->context();
+ } else if (microtask->IsPromiseResolveThenableJobInfo()) {
+ context = Handle<PromiseResolveThenableJobInfo>::cast(microtask)
+ ->resolve()
+ ->context();
} else {
context = Handle<PromiseReactionJobInfo>::cast(microtask)->context();
}
@@ -3238,9 +3239,10 @@ void Isolate::RunMicrotasksInternal() {
result = Execution::TryCall(this, microtask_function,
factory()->undefined_value(), 0, NULL,
&maybe_exception);
- } else if (microtask->IsPromiseContainer()) {
- PromiseResolveThenableJob(Handle<PromiseContainer>::cast(microtask),
- &result, &maybe_exception);
+ } else if (microtask->IsPromiseResolveThenableJobInfo()) {
+ PromiseResolveThenableJob(
+ Handle<PromiseResolveThenableJobInfo>::cast(microtask), &result,
+ &maybe_exception);
} else {
PromiseReactionJob(Handle<PromiseReactionJobInfo>::cast(microtask),
&result, &maybe_exception);
« no previous file with comments | « src/isolate.h ('k') | src/objects.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698