Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Unified Diff: src/objects.h

Issue 2412263002: [promises] rename PromiseContainer to PromiseResolveThenableJobInfo (Closed)
Patch Set: fix build Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/isolate.cc ('k') | src/objects-debug.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects.h
diff --git a/src/objects.h b/src/objects.h
index d147f59c4c1bbb9af0e3efd2e625b5630588b70e..e9f7c14232223b237179b59596a9c48482d4ad16 100644
--- a/src/objects.h
+++ b/src/objects.h
@@ -143,7 +143,7 @@
// - Struct
// - Box
// - AccessorInfo
-// - PromiseContainer
+// - PromiseResolveThenableJobInfo
// - PromiseReactionJobInfo
// - AccessorPair
// - AccessCheckInfo
@@ -400,7 +400,7 @@ const int kStubMinorKeyBits = kSmiValueSize - kStubMajorKeyBits - 1;
V(TYPE_FEEDBACK_INFO_TYPE) \
V(ALIASED_ARGUMENTS_ENTRY_TYPE) \
V(BOX_TYPE) \
- V(PROMISE_CONTAINER_TYPE) \
+ V(PROMISE_RESOLVE_THENABLE_JOB_INFO_TYPE) \
V(PROMISE_REACTION_JOB_INFO_TYPE) \
V(PROTOTYPE_INFO_TYPE) \
V(CONTEXT_EXTENSION_TYPE) \
@@ -508,7 +508,8 @@ const int kStubMinorKeyBits = kSmiValueSize - kStubMajorKeyBits - 1;
// manually.
#define STRUCT_LIST(V) \
V(BOX, Box, box) \
- V(PROMISE_CONTAINER, PromiseContainer, promise_container) \
+ V(PROMISE_RESOLVE_THENABLE_JOB_INFO, PromiseResolveThenableJobInfo, \
+ promise_resolve_thenable_job_info) \
V(PROMISE_REACTION_JOB_INFO, PromiseReactionJobInfo, \
promise_reaction_job_info) \
V(ACCESSOR_INFO, AccessorInfo, accessor_info) \
@@ -692,7 +693,7 @@ enum InstanceType {
TYPE_FEEDBACK_INFO_TYPE,
ALIASED_ARGUMENTS_ENTRY_TYPE,
BOX_TYPE,
- PROMISE_CONTAINER_TYPE,
+ PROMISE_RESOLVE_THENABLE_JOB_INFO_TYPE,
PROMISE_REACTION_JOB_INFO_TYPE,
DEBUG_INFO_TYPE,
BREAK_POINT_INFO_TYPE,
@@ -6682,8 +6683,7 @@ class Struct: public HeapObject {
};
// A container struct to hold state required for PromiseResolveThenableJob.
-// TODO(gsathya): Rename this to be less generic.
-class PromiseContainer : public Struct {
+class PromiseResolveThenableJobInfo : public Struct {
public:
DECL_ACCESSORS(thenable, JSReceiver)
DECL_ACCESSORS(then, JSReceiver)
@@ -6701,12 +6701,12 @@ class PromiseContainer : public Struct {
kBeforeDebugEventOffset + kPointerSize;
static const int kSize = kAfterDebugEventOffset + kPointerSize;
- DECLARE_CAST(PromiseContainer)
- DECLARE_PRINTER(PromiseContainer)
- DECLARE_VERIFIER(PromiseContainer)
+ DECLARE_CAST(PromiseResolveThenableJobInfo)
+ DECLARE_PRINTER(PromiseResolveThenableJobInfo)
+ DECLARE_VERIFIER(PromiseResolveThenableJobInfo)
private:
- DISALLOW_IMPLICIT_CONSTRUCTORS(PromiseContainer);
+ DISALLOW_IMPLICIT_CONSTRUCTORS(PromiseResolveThenableJobInfo);
};
// Struct to hold state required for PromiseReactionJob.
« no previous file with comments | « src/isolate.cc ('k') | src/objects-debug.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698