Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(985)

Issue 2412073003: Remove FOR_EACH_OBSERVER from autofill and password_manager components (Closed)

Created:
4 years, 2 months ago by vabr (Chromium)
Modified:
4 years, 2 months ago
Reviewers:
sebsg
CC:
chromium-reviews, vabr+watchlistpasswordmanager_chromium.org, rouslan+autofill_chromium.org, browser-components-watch_chromium.org, jdonnelly+autofillwatch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org, gcasto+watchlist_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove FOR_EACH_OBSERVER from autofill and password_manager components According to https://groups.google.com/a/chromium.org/d/msg/chromium-dev/udrb7JoPdiY/zxK09HZlAAAJ, the FOR_EACH_OBSERVER macro is now deprecated and should be replaced by range-based for loops. This CL achieves that goal for the autofill and password_manager components. The referenced bug also tracks adding a presubmit script to avoid regressions in the future. The presubmit check is not part of this CL. BUG=655021 Committed: https://crrev.com/d4f239a9796979beb7984664eac50b1c49bcfd14 Cr-Commit-Position: refs/heads/master@{#424987}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -73 lines) Patch
M components/autofill/core/browser/personal_data_manager.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M components/autofill/core/browser/webdata/autofill_webdata_backend_impl.cc View 16 chunks +50 lines, -55 lines 0 comments Download
M components/autofill/core/browser/webdata/autofill_webdata_service.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M components/password_manager/core/browser/log_router.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M components/password_manager/core/browser/password_manager.cc View 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
vabr (Chromium)
Hello Seb, Could you please review this refactoring? No functional change expected. Cheers, Vaclav
4 years, 2 months ago (2016-10-12 12:57:56 UTC) #6
sebsg
Good to know! And thanks for fixing it. LGTM
4 years, 2 months ago (2016-10-12 16:25:57 UTC) #7
vabr (Chromium)
On 2016/10/12 16:25:57, sebsg wrote: > Good to know! And thanks for fixing it. LGTM ...
4 years, 2 months ago (2016-10-13 09:12:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2412073003/1
4 years, 2 months ago (2016-10-13 09:12:32 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-13 09:18:03 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-13 09:19:41 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d4f239a9796979beb7984664eac50b1c49bcfd14
Cr-Commit-Position: refs/heads/master@{#424987}

Powered by Google App Engine
This is Rietveld 408576698