Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Unified Diff: components/password_manager/core/browser/log_router.cc

Issue 2412073003: Remove FOR_EACH_OBSERVER from autofill and password_manager components (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/log_router.cc
diff --git a/components/password_manager/core/browser/log_router.cc b/components/password_manager/core/browser/log_router.cc
index f23c95c5afbbde1a050fdd5a718fd4e9259fe4cd..b07cb3711a903e3190c504ad16c91581346d388d 100644
--- a/components/password_manager/core/browser/log_router.cc
+++ b/components/password_manager/core/browser/log_router.cc
@@ -19,7 +19,8 @@ void LogRouter::ProcessLog(const std::string& text) {
// inactive), because in that case the logs cannot be displayed.
DCHECK(receivers_.might_have_observers());
accumulated_logs_.append(text);
- FOR_EACH_OBSERVER(LogReceiver, receivers_, LogSavePasswordProgress(text));
+ for (LogReceiver& receiver : receivers_)
+ receiver.LogSavePasswordProgress(text);
}
bool LogRouter::RegisterManager(LogManager* manager) {
@@ -38,8 +39,8 @@ std::string LogRouter::RegisterReceiver(LogReceiver* receiver) {
DCHECK(accumulated_logs_.empty() || receivers_.might_have_observers());
if (!receivers_.might_have_observers()) {
- FOR_EACH_OBSERVER(LogManager, managers_,
- OnLogRouterAvailabilityChanged(true));
+ for (LogManager& manager : managers_)
+ manager.OnLogRouterAvailabilityChanged(true);
}
receivers_.AddObserver(receiver);
return accumulated_logs_;
@@ -52,8 +53,8 @@ void LogRouter::UnregisterReceiver(LogReceiver* receiver) {
// |accumulated_logs_| can become very long; use the swap instead of clear()
// to ensure that the memory is freed.
std::string().swap(accumulated_logs_);
- FOR_EACH_OBSERVER(LogManager, managers_,
- OnLogRouterAvailabilityChanged(false));
+ for (LogManager& manager : managers_)
+ manager.OnLogRouterAvailabilityChanged(false);
}
}

Powered by Google App Engine
This is Rietveld 408576698