Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Unified Diff: components/password_manager/core/browser/password_manager.cc

Issue 2412073003: Remove FOR_EACH_OBSERVER from autofill and password_manager components (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/password_manager/core/browser/log_router.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/password_manager/core/browser/password_manager.cc
diff --git a/components/password_manager/core/browser/password_manager.cc b/components/password_manager/core/browser/password_manager.cc
index 1f9577f6067953fbdad93c4ebe4e8a156d510d14..40d749ffe4623a6fc3f09aee44f9f24b27fa93df 100644
--- a/components/password_manager/core/browser/password_manager.cc
+++ b/components/password_manager/core/browser/password_manager.cc
@@ -170,7 +170,8 @@ PasswordManager::PasswordManager(PasswordManagerClient* client)
}
PasswordManager::~PasswordManager() {
- FOR_EACH_OBSERVER(LoginModelObserver, observers_, OnLoginModelDestroying());
+ for (LoginModelObserver& observer : observers_)
+ observer.OnLoginModelDestroying();
}
void PasswordManager::GenerationAvailableForForm(const PasswordForm& form) {
@@ -811,8 +812,8 @@ void PasswordManager::AutofillHttpAuth(
observers_.might_have_observers());
}
- FOR_EACH_OBSERVER(LoginModelObserver, observers_,
- OnAutofillDataAvailable(preferred_match));
+ for (LoginModelObserver& observer : observers_)
+ observer.OnAutofillDataAvailable(preferred_match);
DCHECK(!best_matches.empty());
client_->PasswordWasAutofilled(best_matches,
best_matches.begin()->second->origin, nullptr);
« no previous file with comments | « components/password_manager/core/browser/log_router.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698