libyuv: Switch bots over to GN by default.

libyuv: Switch bots over to GN by default.

* Change the old GN bots to now be GYP bots.
* Keep Visual Studio 2010 and 2012 for GYP only since GN only supports
2013 and 2015.

BUG=chromium:652188
Committed: https://chromium.googlesource.com/chromium/tools/build/+/94aa3062f0f4cc2542d375cf45706c7e2742c714

[kjellander_chromium, 2016-10-12 05:39:08]

Patchset #1 (id:1) has been deleted

[kjellander_chromium, 2016-10-12 05:58:14]

Patchset #1 (id:20001) has been deleted

[kjellander_chromium, 2016-10-12 05:59:33]

The CQ bit was checked by kjellander@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-12 05:59:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kjellander_chromium, 2016-10-12 06:06:31]

kjellander@chromium.org changed reviewers:
+ ehmaldonado@chromium.org, fbarchard@chromium.org

[kjellander_chromium, 2016-10-12 06:06:32]

I took a stab at this as I noticed compile fails on Win Clang GN for libyuv,
which is currently not covered (but will be with this CL). I filed
https://bugs.chromium.org/p/libyuv/issues/detail?id=649 for that.

[commit-bot: I haz the power, 2016-10-12 06:08:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-12 06:08:58]

Dry run: Try jobs failed on following builders:
  build_presubmit on master.chromium.buildbucket.swarming (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/31d04f585972e910)

[ehmaldonado_chromium, 2016-10-12 13:59:08]

On 2016/10/12 06:06:32, kjellander_chromium wrote:
> I took a stab at this as I noticed compile fails on Win Clang GN for libyuv,
> which is currently not covered (but will be with this CL). I filed
> https://bugs.chromium.org/p/libyuv/issues/detail?id=649 for that.

Just a couple of questions.
LGTM

[ehmaldonado_chromium, 2016-10-12 13:59:30]

https://codereview.chromium.org/2412033002/diff/60001/scripts/slave/recipe_mo...
File scripts/slave/recipe_modules/chromium/config.py (right):

https://codereview.chromium.org/2412033002/diff/60001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/chromium/config.py:333:
c.gn_args.append('is_component=true')
Shouldn't it be is_component_build?

https://codereview.chromium.org/2412033002/diff/60001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/chromium/config.py:472:
c.gn_args.append('is_tsan=true')
Isn't there anything similar to disable_nacl in GN?
A quick code search suggested enable_nacl, is it false by default?

https://codereview.chromium.org/2412033002/diff/60001/scripts/slave/recipe_mo...
File scripts/slave/recipe_modules/libyuv/builders.py (left):

https://codereview.chromium.org/2412033002/diff/60001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/libyuv/builders.py:105: 'Win64 Debug (VS2012)': {
Why remove it?

[kjellander_chromium, 2016-10-13 00:52:43]

kjellander@chromium.org changed reviewers:
+ iannucci@chromium.org

[kjellander_chromium, 2016-10-13 00:52:45]

+iannucci for scripts/slave/recipe_modules/chromium/config.py

https://codereview.chromium.org/2412033002/diff/60001/scripts/slave/recipe_mo...
File scripts/slave/recipe_modules/chromium/config.py (right):

https://codereview.chromium.org/2412033002/diff/60001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/chromium/config.py:333:
c.gn_args.append('is_component=true')
On 2016/10/12 13:59:30, ehmaldonado_chromium wrote:
> Shouldn't it be is_component_build?

Good catch! You're right.

https://codereview.chromium.org/2412033002/diff/60001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/chromium/config.py:472:
c.gn_args.append('is_tsan=true')
On 2016/10/12 13:59:30, ehmaldonado_chromium wrote:
> Isn't there anything similar to disable_nacl in GN?
> A quick code search suggested enable_nacl, is it false by default?

Good reviewing, looking up how things work. In this case however, NaCl is
something that is Chromium specific so that won't have any effect in WebRTC:
https://developer.chrome.com/native-client

https://codereview.chromium.org/2412033002/diff/60001/scripts/slave/recipe_mo...
File scripts/slave/recipe_modules/libyuv/builders.py (left):

https://codereview.chromium.org/2412033002/diff/60001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/libyuv/builders.py:105: 'Win64 Debug (VS2012)': {
On 2016/10/12 13:59:30, ehmaldonado_chromium wrote:
> Why remove it?

Whops, that was a mistake. I initially was going to remove 2010 and 2012 since
they're not supported in GN but then I realized we can keep them on GYP for now.
I seem to have missed restoring this one. Did that in the new patch set now.

[iannucci, 2016-10-13 01:23:01]

config.py change lgtm

[kjellander_chromium, 2016-10-17 06:41:36]

The CQ bit was checked by kjellander@chromium.org

[kjellander_chromium, 2016-10-17 06:41:36]

The patchset sent to the CQ was uploaded after l-g-t-m from
ehmaldonado@chromium.org
Link to the patchset: https://codereview.chromium.org/2412033002/#ps80001
(title: "Fixed review comments")

[commit-bot: I haz the power, 2016-10-17 06:41:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kjellander_chromium, 2016-10-17 07:25:29]

The CQ bit was checked by kjellander@chromium.org

[kjellander_chromium, 2016-10-17 07:25:30]

The patchset sent to the CQ was uploaded after l-g-t-m from
ehmaldonado@chromium.org, iannucci@chromium.org
Link to the patchset: https://codereview.chromium.org/2412033002/#ps100001
(title: "Rebased")

[commit-bot: I haz the power, 2016-10-17 07:25:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kjellander_chromium, 2016-10-17 07:49:02]

The CQ bit was unchecked by kjellander@chromium.org

[kjellander_chromium, 2016-10-17 08:50:46]

Description was changed from

==========
libyuv: Switch bots over to GN by default.

Change the old GN bots to now be GYP bots.
Keep Visual Studio 2010 and 2012 for GYP only since GN only supports
2013 and 2015.

BUG=chromium:652188
==========

to

==========
libyuv: Switch bots over to GN by default.

Chromium recipe: add is_component_build=false for static_library configs.

* Change the old GN bots to now be GYP bots.
* Keep Visual Studio 2010 and 2012 for GYP only since GN only supports
2013 and 2015.

BUG=chromium:652188
==========

[kjellander_chromium, 2016-10-17 08:50:46]

kjellander@chromium.org changed reviewers:
+ dpranke@chromium.org

[kjellander_chromium, 2016-10-17 08:51:07]

The CQ bit was checked by kjellander@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-17 08:51:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kjellander_chromium, 2016-10-17 08:54:08]

Description was changed from

==========
libyuv: Switch bots over to GN by default.

Chromium recipe: add is_component_build=false for static_library configs.

* Change the old GN bots to now be GYP bots.
* Keep Visual Studio 2010 and 2012 for GYP only since GN only supports
2013 and 2015.

BUG=chromium:652188
==========

to

==========
libyuv: Switch bots over to GN by default.

* Change the old GN bots to now be GYP bots.
* Keep Visual Studio 2010 and 2012 for GYP only since GN only supports
2013 and 2015.

BUG=chromium:652188
==========

[kjellander_chromium, 2016-10-17 08:54:08]

kjellander@chromium.org changed reviewers:
- dpranke@chromium.org, iannucci@chromium.org

[kjellander_chromium, 2016-10-17 08:54:57]

kjellander@chromium.org changed reviewers:
+ iannucci@chromium.org

[commit-bot: I haz the power, 2016-10-17 09:03:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-17 09:03:24]

Dry run: This issue passed the CQ dry run.

[kjellander_chromium, 2016-10-17 09:48:27]

Patchset #5 (id:120001) has been deleted

[kjellander_chromium, 2016-10-17 09:59:57]

Patchset #5 (id:140001) has been deleted

[kjellander_chromium, 2016-10-17 10:04:27]

kjellander@chromium.org changed reviewers:
+ dpranke@chromium.org

[kjellander_chromium, 2016-10-17 10:04:29]

Reverted the is_component_build changes to the chromium recipe module to be sure
not affecting any other project.

Adding Dirk to review mostly FYI. I think it's better you and Robbie discuss how
to solve the debug builds that wants is_component_build=false on a higher level.

https://codereview.chromium.org/2412033002/diff/100001/scripts/slave/recipe_m...
File scripts/slave/recipe_modules/chromium/config.py (right):

https://codereview.chromium.org/2412033002/diff/100001/scripts/slave/recipe_m...
scripts/slave/recipe_modules/chromium/config.py:337:
c.gn_args.append('is_component_build=true')
I realized these two shouldn't be here since they're implicitly decided by
BUILD_CONFIG for GN. Many configurations for Android and iOS specify
static_library config though, so it could make sense to put it there but I
didn't dare changing that in this CL since it could affect a lot of builds (I
wasn't sure if every recipe that wasn't updated actually runs MB).

https://codereview.chromium.org/2412033002/diff/100001/scripts/slave/recipes/...
File
scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_android32_mips_debug.json
(right):

https://codereview.chromium.org/2412033002/diff/100001/scripts/slave/recipes/...
scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_android32_mips_debug.json:146:
"--args=is_component_build=true is_component_build=false is_clang=true
is_debug=true target_os=\"android\" target_cpu=\"mipsel\" use_goma=true
goma_dir=\"[CACHE]/cipd/goma\""
This was clearly wrong, so it was good the presubmits failed so I could figure
this out after some digging

[kjellander_chromium, 2016-10-17 10:04:54]

The CQ bit was checked by kjellander@chromium.org

[kjellander_chromium, 2016-10-17 10:04:56]

The patchset sent to the CQ was uploaded after l-g-t-m from
ehmaldonado@chromium.org, iannucci@chromium.org
Link to the patchset: https://codereview.chromium.org/2412033002/#ps160001
(title: "Reverted is_component_build changes in chromium recipe module.")

[commit-bot: I haz the power, 2016-10-17 10:05:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-17 10:15:19]

Description was changed from

==========
libyuv: Switch bots over to GN by default.

* Change the old GN bots to now be GYP bots.
* Keep Visual Studio 2010 and 2012 for GYP only since GN only supports
2013 and 2015.

BUG=chromium:652188
==========

to

==========
libyuv: Switch bots over to GN by default.

* Change the old GN bots to now be GYP bots.
* Keep Visual Studio 2010 and 2012 for GYP only since GN only supports
2013 and 2015.

BUG=chromium:652188

Committed:
https://chromium.googlesource.com/chromium/tools/build/+/94aa3062f0f4cc2542d3...
==========

[commit-bot: I haz the power, 2016-10-17 10:15:21]

Committed patchset #5 (id:160001) as
https://chromium.googlesource.com/chromium/tools/build/+/94aa3062f0f4cc2542d3...