Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Side by Side Diff: scripts/slave/recipe_modules/libyuv/chromium_config.py

Issue 2412033002: libyuv: Switch bots over to GN by default. (Closed)
Patch Set: Reverted is_component_build changes in chromium recipe module. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « scripts/slave/recipe_modules/libyuv/builders.py ('k') | scripts/slave/recipes/libyuv/libyuv.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 from recipe_engine.config import BadConf 5 from recipe_engine.config import BadConf
6 6
7 import DEPS 7 import DEPS
8 CONFIG_CTX = DEPS['chromium'].CONFIG_CTX 8 CONFIG_CTX = DEPS['chromium'].CONFIG_CTX
9 from recipe_engine.config_types import Path 9 from recipe_engine.config_types import Path
10 10
(...skipping 11 matching lines...) Expand all
22 _libyuv_common(c) 22 _libyuv_common(c)
23 23
24 @CONFIG_CTX(includes=['ninja', 'gcc', 'goma']) 24 @CONFIG_CTX(includes=['ninja', 'gcc', 'goma'])
25 def libyuv_gcc(c): 25 def libyuv_gcc(c):
26 _libyuv_common(c) 26 _libyuv_common(c)
27 27
28 @CONFIG_CTX(includes=['android']) 28 @CONFIG_CTX(includes=['android'])
29 def libyuv_android(c): 29 def libyuv_android(c):
30 if c.TARGET_ARCH == 'intel' and c.TARGET_BITS == 32: 30 if c.TARGET_ARCH == 'intel' and c.TARGET_BITS == 32:
31 c.gyp_env.GYP_DEFINES['android_full_debug'] = 1 31 c.gyp_env.GYP_DEFINES['android_full_debug'] = 1
32 c.gn_args.append('android_full_debug=true')
33
34 _libyuv_static_build(c)
32 35
33 @CONFIG_CTX(includes=['android_clang']) 36 @CONFIG_CTX(includes=['android_clang'])
34 def libyuv_android_clang(c): 37 def libyuv_android_clang(c):
35 pass 38 _libyuv_static_build(c)
36 39
37 @CONFIG_CTX(includes=['chromium', 'static_library']) 40 @CONFIG_CTX(includes=['chromium', 'static_library'])
38 def libyuv_ios(c): 41 def libyuv_ios(c):
39 if c.HOST_PLATFORM != 'mac': 42 if c.HOST_PLATFORM != 'mac':
40 raise BadConf('Only "mac" host platform is supported for iOS (got: "%s")' % 43 raise BadConf('Only "mac" host platform is supported for iOS (got: "%s")' %
41 c.HOST_PLATFORM) # pragma: no cover 44 c.HOST_PLATFORM) # pragma: no cover
42 if c.TARGET_PLATFORM != 'ios': 45 if c.TARGET_PLATFORM != 'ios':
43 raise BadConf('Only "ios" target platform is supported (got: "%s")' % 46 raise BadConf('Only "ios" target platform is supported (got: "%s")' %
44 c.TARGET_PLATFORM) # pragma: no cover 47 c.TARGET_PLATFORM) # pragma: no cover
45 c.build_config_fs = c.BUILD_CONFIG + '-iphoneos' 48 c.build_config_fs = c.BUILD_CONFIG + '-iphoneos'
46 49
47 gyp_defs = c.gyp_env.GYP_DEFINES 50 gyp_defs = c.gyp_env.GYP_DEFINES
48 gyp_defs['OS'] = c.TARGET_PLATFORM 51 gyp_defs['OS'] = c.TARGET_PLATFORM
49 if c.TARGET_BITS == 64: 52 if c.TARGET_BITS == 64:
50 gyp_defs['target_subarch'] = 'arm64' 53 gyp_defs['target_subarch'] = 'arm64'
51 54
55 c.gn_args.append('target_os=%s' % c.TARGET_PLATFORM)
52 _libyuv_common(c) 56 _libyuv_common(c)
57 _libyuv_static_build(c)
53 58
54 def _libyuv_common(c): 59 def _libyuv_common(c):
55 c.compile_py.default_targets = ['All'] 60 c.compile_py.default_targets = []
61
62 def _libyuv_static_build(c):
63 # TODO(kjellander): Investigate moving this into chromium recipe module's
64 # static_library config instead.
65 if c.BUILD_CONFIG == 'Debug':
66 # GN defaults to component builds for Debug, but some build configurations
67 # (Android and iOS) needs it to be static.
68 c.gn_args.append('is_component_build=false')
OLDNEW
« no previous file with comments | « scripts/slave/recipe_modules/libyuv/builders.py ('k') | scripts/slave/recipes/libyuv/libyuv.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698