libyuv: Switch bots over to GN by default.

scripts/slave/recipe_modules/chromium/config.py

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import pipes
 
 from recipe_engine.config import config_item_context, ConfigGroup
 from recipe_engine.config import Dict, List, Single, Static, Set, BadConf
 from recipe_engine.config_types import Path
 
@@ skipping 223 matching lines @@
 @config_ctx()
 def msvs2010(c):
   c.gyp_env.GYP_MSVS_VERSION = '2010'
 
 @config_ctx()
 def msvs2012(c):
   c.gyp_env.GYP_MSVS_VERSION = '2012'
 
 @config_ctx()
 def msvs2013(c):
+  c.gn_args.append('visual_studio_version=2013')
   c.gyp_env.GYP_MSVS_VERSION = '2013'
 
 @config_ctx()
 def msvs2015(c):
+  c.gn_args.append('visual_studio_version=2015')
   c.gyp_env.GYP_MSVS_VERSION = '2015'
 
 @config_ctx()
 def goma_canary(c):
   c.compile_py.goma_canary = True
   c.compile_py.goma_hermetic = 'error'
   c.compile_py.goma_failfast = True
 
 @config_ctx()
 def goma_staging(c):
@@ skipping 14 matching lines @@
   c.compile_py.ninja_confirm_noop = True
 
 @config_ctx(group='builder')
 def xcode(c):  # pragma: no cover
   if c.HOST_PLATFORM != 'mac':
     raise BadConf('can not use xcodebuild on "%s"' % c.HOST_PLATFORM)
   c.gyp_env.GYP_GENERATORS.add('xcode')
 
 def _clang_common(c):
   c.compile_py.compiler = 'clang'
+  c.gn_args.append('is_clang=true')
   c.gyp_env.GYP_DEFINES['clang'] = 1
 
 @config_ctx(group='compiler')
 def clang(c):
   _clang_common(c)
 
 @config_ctx(group='compiler')
 def gcc(c):
+  c.gn_args.append('is_clang=false')
   c.gyp_env.GYP_DEFINES['clang'] = 0
 
 @config_ctx(group='compiler')
 def default_compiler(c):
   if c.TARGET_PLATFORM in ('mac', 'ios'):
     _clang_common(c)
 
 @config_ctx(deps=['compiler', 'builder'], group='distributor')
 def goma(c):
   if not c.compile_py.compiler:
     c.compile_py.compiler = 'goma'
   elif c.compile_py.compiler == 'clang':
     c.compile_py.compiler = 'goma-clang'
   else:  # pragma: no cover
     raise BadConf('goma config doesn\'t understand %s' % c.compile_py.compiler)
 
   if c.TARGET_PLATFORM == 'win' and c.compile_py.compiler != 'goma-clang':
     fastbuild(c)
 
 @config_ctx()
 def dcheck(c, invert=False):
+  c.gn_args.append('dcheck_always_on=%s' % str(not invert).lower())
   c.gyp_env.GYP_DEFINES['dcheck_always_on'] = int(not invert)
 
 @config_ctx()
 def fastbuild(c, invert=False):
+  c.gn_args.append('symbol_level=%d' % (1 if invert else 2))
   c.gyp_env.GYP_DEFINES['fastbuild'] = int(not invert)
 
 @config_ctx()
 def no_dump_symbols(c):
   c.gyp_env.GYP_DEFINES['linux_dump_symbols'] = 0
 
 @config_ctx()
 def isolation_mode_noop(c):
   c.gyp_env.GYP_DEFINES['test_isolation_mode'] = 'noop'
 
 @config_ctx(group='link_type')
 def shared_library(c):
+  c.gn_args.append('is_component=true')

[ehmaldonado_chromium, 2016/10/12 13:59:30]

Shouldn't it be is_component_build?

[kjellander_chromium, 2016/10/13 00:52:45]

Good catch! You're right.

   c.gyp_env.GYP_DEFINES['component'] = 'shared_library'
 
 @config_ctx(group='link_type')
 def static_library(c):
+  c.gn_args.append('is_component=false')
   c.gyp_env.GYP_DEFINES['component'] = 'static_library'
 
 @config_ctx()
 def ffmpeg_branding(c, branding=None):
   if branding:
     c.gyp_env.GYP_DEFINES['ffmpeg_branding'] = branding
 
 @config_ctx()
 def proprietary_codecs(c, invert=False):
   c.gyp_env.GYP_DEFINES['proprietary_codecs'] = int(not invert)
@@ skipping 33 matching lines @@
 
 @config_ctx(deps=['compiler'])
 def asan(c):
   if 'clang' not in c.compile_py.compiler:  # pragma: no cover
     raise BadConf('asan requires clang')
   c.runtests.swarming_tags |= {'asan:1'}
   if c.TARGET_PLATFORM in ['mac', 'win']:
     # Set fastbuild=0 and prevent other configs from changing it.
     fastbuild(c, invert=True, optional=False)
 
+  c.gn_args.append('is_asan=true')
   c.gyp_env.GYP_DEFINES['asan'] = 1
   if c.TARGET_PLATFORM != 'android' and c.TARGET_BITS == 64:
     # LSAN isn't supported on Android or 32 bits platforms.
+    c.gn_args.append('is_lsan=true')
     c.gyp_env.GYP_DEFINES['lsan'] = 1
 
 @config_ctx(deps=['compiler'])
 def lsan(c):
   c.runtests.enable_lsan = True
   c.runtests.swarming_extra_args += ['--lsan=1']
   c.runtests.swarming_tags |= {'lsan:1'}
 
 # TODO(infra,earthdok,glider): Make this a gyp variable. This is also not a
 # good name as only v8 builds release symbolized with -O2 while
 # chromium.lkgr uses -O1.
 @config_ctx()
 def asan_symbolized(c):
   c.gyp_env.GYP_DEFINES['release_extra_cflags'] = (
       '-fno-inline-functions -fno-inline')
 
 @config_ctx()
 def sanitizer_coverage(c):
   c.gyp_env.GYP_DEFINES['sanitizer_coverage'] = 'edge'
 
 @config_ctx(deps=['compiler'])
 def msan(c):
   if 'clang' not in c.compile_py.compiler:  # pragma: no cover
     raise BadConf('msan requires clang')
   c.runtests.swarming_tags |= {'msan:1'}
+  c.gn_args.append('is_msan=true')
   c.gyp_env.GYP_DEFINES['msan'] = 1
 
 @config_ctx()
 def msan_no_origin_tracking(c):
   # Don't track the chain of stores leading from allocation site to use site.
   c.gyp_env.GYP_DEFINES['msan_track_origins'] = 0
 
 @config_ctx()
 def msan_full_origin_tracking(c):
   # Track the chain of stores leading from allocation site to use site.
   c.gyp_env.GYP_DEFINES['msan_track_origins'] = 2
 
 # This is currently needed to make tests return a non-zero exit code when an
 # UBSan failure happens.
 # TODO(kjellander,samsonov): Remove when the upstream bug
 # (https://llvm.org/bugs/show_bug.cgi?id=25569) is fixed.
 @config_ctx()
 def ubsan_fail_on_errors(c):
   c.gyp_env.GYP_DEFINES['release_extra_cflags'] = (
       '-fno-sanitize-recover=undefined')
 
 @config_ctx(deps=['compiler'], includes=['ubsan_fail_on_errors'])
 def ubsan(c):
   if 'clang' not in c.compile_py.compiler:  # pragma: no cover
     raise BadConf('ubsan requires clang')
+  c.gn_args.append('is_ubsan=true')
   c.gyp_env.GYP_DEFINES['ubsan'] = 1
 
 @config_ctx(deps=['compiler'], includes=['ubsan_fail_on_errors'])
 def ubsan_vptr(c):
   if 'clang' not in c.compile_py.compiler:  # pragma: no cover
     raise BadConf('ubsan_vptr requires clang')
+  c.gn_args.append('is_ubsan_vptr=true')
   c.gyp_env.GYP_DEFINES['ubsan_vptr'] = 1
 
 @config_ctx()
 def prebuilt_instrumented_libraries(c):
   c.gyp_env.GYP_DEFINES['use_prebuilt_instrumented_libraries'] = 1
 
 @config_ctx(group='memory_tool')
 def memcheck(c):
   _memory_tool(c, 'memcheck')
   c.gyp_env.GYP_DEFINES['build_for_tool'] = 'memcheck'
 
 @config_ctx(deps=['compiler'], group='memory_tool')
 def tsan2(c):
   if 'clang' not in c.compile_py.compiler:  # pragma: no cover
     raise BadConf('tsan2 requires clang')
   c.runtests.swarming_tags |= {'tsan:1'}
+  c.gn_args.append('is_tsan=true')

[ehmaldonado_chromium, 2016/10/12 13:59:30]

Isn't there anything similar to disable_nacl in GN?
A quick code search suggested enable_nacl, is it false by default?

[kjellander_chromium, 2016/10/13 00:52:45]

Good reviewing, looking up how things work. In this case however, NaCl is
something that is Chromium specific so that won't have any effect in WebRTC:
https://developer.chrome.com/native-client

   gyp_defs = c.gyp_env.GYP_DEFINES
   gyp_defs['tsan'] = 1
   gyp_defs['disable_nacl'] = 1
 
 @config_ctx()
 def syzyasan_compile_only(c):
   gyp_defs = c.gyp_env.GYP_DEFINES
   gyp_defs['syzyasan'] = 1
   gyp_defs['win_z7'] = 0
 
@@ skipping 332 matching lines @@
   c.gyp_env.GYP_DEFINES['internal_gles2_conform_tests'] = 1
 
 @config_ctx()
 def build_angle_deqp_tests(c):
   c.gyp_env.GYP_DEFINES['build_angle_deqp_tests'] = 1
 
 @config_ctx()
 def force_mac_toolchain(c):
   c.env.FORCE_MAC_TOOLCHAIN = 1
   c.gyp_env.FORCE_MAC_TOOLCHAIN = 1