Add an enable D3D11 flag and blacklist specific intel drivers and windows vista from using D3D11.

Add an enable D3D11 flag and blacklist specific intel drivers and windows vista from using D3D11.

BUG=256863
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223716

[Geoff Lang, 2013-09-13 15:40:29]

PTAL

[Zhenyao Mo, 2013-09-13 18:12:20]

The Cl looks good, but why all the bots are red?

Please retry them and make sure they are green.

Also add piman as owner.

[Geoff Lang, 2013-09-13 18:18:03]

On 2013/09/13 18:12:20, Zhenyao Mo wrote:
> The Cl looks good, but why all the bots are red?
> 
> Please retry them and make sure they are green.
> 
> Also add piman as owner.

As far as I can tell, all the bots are red because I'm not a comitter and don't
have the privileges to run them.

[geoff.lang, 2013-09-16 13:26:21]

On 2013/09/13 18:18:03, Geoff Lang wrote:
> On 2013/09/13 18:12:20, Zhenyao Mo wrote:
> > The Cl looks good, but why all the bots are red?
> > 
> > Please retry them and make sure they are green.
> > 
> > Also add piman as owner.
> 
> As far as I can tell, all the bots are red because I'm not a comitter and
don't
> have the privileges to run them.

Some of the try jobs may need to be re-run.  As far as I can tell, the failures
have nothing to do with these changes.

[piman, 2013-09-16 17:01:06]

https://codereview.chromium.org/24120004/diff/1/ui/gl/gl_surface_egl.cc
File ui/gl/gl_surface_egl.cc (right):

https://codereview.chromium.org/24120004/diff/1/ui/gl/gl_surface_egl.cc#newco...
ui/gl/gl_surface_egl.cc:108:
CommandLine::ForCurrentProcess()->HasSwitch(switches::kEnableD3D11)) {
So, by default, this disables D3D11 everywhere (because nothing sets this flag
by default).
Is that what this CL intends?
Can you fix the description if that's the case?

[Geoff Lang, 2013-09-16 17:58:34]

On 2013/09/16 17:01:06, piman wrote:
> https://codereview.chromium.org/24120004/diff/1/ui/gl/gl_surface_egl.cc
> File ui/gl/gl_surface_egl.cc (right):
> 
>
https://codereview.chromium.org/24120004/diff/1/ui/gl/gl_surface_egl.cc#newco...
> ui/gl/gl_surface_egl.cc:108:
> CommandLine::ForCurrentProcess()->HasSwitch(switches::kEnableD3D11)) {
> So, by default, this disables D3D11 everywhere (because nothing sets this flag
> by default).
> Is that what this CL intends?
> Can you fix the description if that's the case?

Previously, D3D11 was always disabled by default via the driver bug in
gpu_driver_bug_list_json.cc that would set disable-d3d11 on all windows systems.
 Now, the disable-d3d11 flag is only enabled on some systems (Windows Vista and
lower/some intel drivers) but users can now opt-in with the enable-d3d11.  The
plan is to put the enable-d3d11 flag on by default once the D3D11 backend of
ANGLE has been tested enough.

[piman, 2013-09-16 19:36:06]

OK, got it, thanks. LGTM.

[Zhenyao Mo, 2013-09-17 18:27:48]

On 2013/09/16 19:36:06, piman wrote:
> OK, got it, thanks. LGTM.

LGTM

[commit-bot: I haz the power, 2013-09-17 18:31:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/geofflang@chromium.org/24120004/1

[commit-bot: I haz the power, 2013-09-17 18:31:15]

Failed to apply patch for gpu/config/gpu_driver_bug_list_json.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file gpu/config/gpu_driver_bug_list_json.cc
  Hunk #1 FAILED at 85.
  Hunk #3 succeeded at 624 with fuzz 2 (offset 26 lines).
  1 out of 3 hunks FAILED -- saving rejects to file
gpu/config/gpu_driver_bug_list_json.cc.rej

Patch:       gpu/config/gpu_driver_bug_list_json.cc
Index: gpu/config/gpu_driver_bug_list_json.cc
diff --git a/gpu/config/gpu_driver_bug_list_json.cc
b/gpu/config/gpu_driver_bug_list_json.cc
index
79dc6c1e55c68be2a3efb93d2432d818df069f00..a42f0f5f029b298c63393d4e2f5448f1cb6d42ed
100644
--- a/gpu/config/gpu_driver_bug_list_json.cc
+++ b/gpu/config/gpu_driver_bug_list_json.cc
@@ -85,7 +85,7 @@ const char kGpuDriverBugListJson[] = LONG_STRING_CONST(
 {
   "name": "gpu driver bug list",
   // Please update the version number whenever you change this file.
-  "version": "2.13",
+  "version": "2.14",
   "entries": [
     {
       "id": 1,
@@ -408,9 +408,13 @@ const char kGpuDriverBugListJson[] = LONG_STRING_CONST(
     },
     {
       "id": 26,
-      "description": "Disable use of Direct3D 11 on Windows",
+      "description": "Disable use of Direct3D 11 on Windows Vista and lower.",
       "os": {
-        "type": "win"
+        "type": "win",
+        "version": {
+          "op": "<=",
+          "number": "6.0"
+        }
       },
       "features": [
         "disable_d3d11"
@@ -594,6 +598,22 @@ const char kGpuDriverBugListJson[] = LONG_STRING_CONST(
       "features": [
         "use_virtualized_gl_contexts"
       ]
+    },
+    {
+      "id": 39,
+      "cr_bugs": [259978],
+      "description": "Intel D3D driver crashes when sharing surfaces between
D3D9 and D3D11.",
+      "os": {
+        "type": "win"
+      },
+      "vendor_id": "0x8086",
+      "driver_version": {
+        "op": ">=",
+        "number": "9.18.10.0"
+      },
+      "features": [
+        "disable_d3d11"
+      ]
     }
   ]
 }

[commit-bot: I haz the power, 2013-09-17 18:47:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/geofflang@chromium.org/24120004/21001

[commit-bot: I haz the power, 2013-09-17 22:27:33]

Change committed as 223716