Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 2411903003: Fix tab redirect to apps in Herb mode. (Closed)

Created:
4 years, 2 months ago by Ted C
Modified:
4 years, 2 months ago
Reviewers:
CC:
chromium-reviews, lizeb+watch-custom-tabs_chromium.org
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Fix tab redirect to apps in Herb mode. BUG=653254 Review-Url: https://codereview.chromium.org/2398833002 Cr-Commit-Position: refs/heads/master@{#423355} Support native app redirects to herb. If in Herb mode, use the same intent handling logic as Chrome, which more aggressively intents out to external applications than a normal CCT. BUG=653254 Review-Url: https://codereview.chromium.org/2412613002 Cr-Commit-Position: refs/heads/master@{#424483} Committed: https://chromium.googlesource.com/chromium/src/+/1005c8597f728173c822bdc1d8a01609f8cbd02c

Patch Set 1 #

Messages

Total messages: 3 (1 generated)
Ted C
Committed patchset #1 (id:1) manually as 1005c8597f728173c822bdc1d8a01609f8cbd02c.
4 years, 2 months ago (2016-10-11 20:04:51 UTC) #2
dgn
4 years, 2 months ago (2016-10-12 10:09:08 UTC) #3
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2419483002/ by dgn@chromium.org.

The reason for reverting is: Does not compile:

../../chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java:857:
error: method updateHerbIntent in class ChromeLauncherActivity cannot be applied
to given types;
               
ChromeLauncherActivity.updateHerbIntent(ChromeTabbedActivity.this,
                                      ^
  required: Context,Intent
  found: ChromeTabbedActivity,Intent,Uri
  reason: actual and formal argument lists differ in length.

Powered by Google App Engine
This is Rietveld 408576698