Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 2398833002: Fix tab redirect to apps in Herb mode. (Closed)

Created:
4 years, 2 months ago by Ted C
Modified:
4 years, 2 months ago
Reviewers:
gone, Maria
CC:
chromium-reviews, lizeb+watch-custom-tabs_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix tab redirect to apps in Herb mode. BUG=653254 Committed: https://crrev.com/8354646c712447f6697300c465bb8c940d053ee0 Cr-Commit-Position: refs/heads/master@{#423355}

Patch Set 1 #

Patch Set 2 : Switch extra logic a bit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -12 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabIntentDataProvider.java View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/document/ChromeLauncherActivity.java View 1 4 chunks +14 lines, -11 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/util/IntentUtils.java View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Ted C
mariakhomenko || dfalcantara - PTAL
4 years, 2 months ago (2016-10-05 23:15:45 UTC) #2
Maria
lgtm Thanks
4 years, 2 months ago (2016-10-05 23:20:46 UTC) #3
gone
lgtm
4 years, 2 months ago (2016-10-05 23:30:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2398833002/20001
4 years, 2 months ago (2016-10-05 23:34:13 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-06 00:27:22 UTC) #7
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 00:30:36 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8354646c712447f6697300c465bb8c940d053ee0
Cr-Commit-Position: refs/heads/master@{#423355}

Powered by Google App Engine
This is Rietveld 408576698